From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sasha Levin <sashal@kernel.org>
Cc: gregkh@linuxfoundation.org, malin.jonsson@ericsson.com,
mika.westerberg@linux.intel.com, oliver.barta@aptiv.com,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] pinctrl: intel: Avoid potential glitches if pin is in GPIO" failed to apply to 4.19-stable tree
Date: Tue, 12 Nov 2019 11:11:33 +0200 [thread overview]
Message-ID: <20191112091133.GQ32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191111131907.GR4787@sasha-vm>
On Mon, Nov 11, 2019 at 08:19:07AM -0500, Sasha Levin wrote:
> On Mon, Nov 11, 2019 at 06:59:53AM +0100, gregkh@linuxfoundation.org wrote:
> >
> > The patch below does not apply to the 4.19-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------ original commit in Linus's tree ------------------
> >
> > From 29c2c6aa32405dfee4a29911a51ba133edcedb0f Mon Sep 17 00:00:00 2001
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Date: Mon, 14 Oct 2019 12:51:04 +0300
> > Subject: [PATCH] pinctrl: intel: Avoid potential glitches if pin is in GPIO
> > mode
> >
> > When consumer requests a pin, in order to be on the safest side,
> > we switch it first to GPIO mode followed by immediate transition
> > to the input state. Due to posted writes it's luckily to be a single
> > I/O transaction.
> >
> > However, if firmware or boot loader already configures the pin
> > to the GPIO mode, user expects no glitches for the requested pin.
> > We may check if the pin is pre-configured and leave it as is
> > till the actual consumer toggles its state to avoid glitches.
>
> I've queued it up for 4.19, it was just a minor conflict with
> e58926e781d8 ("pinctrl: intel: Use GENMASK() consistently").
Thank you!
> However, for 4.14 and older:
>
> > Fixes: 7981c0015af2 ("pinctrl: intel: Add Intel Sunrisepoint pin controller and GPIO support")
> > Depends-on: f5a26acf0162 ("pinctrl: intel: Initialize GPIO properly when used through irqchip")
>
> We need to take this "Depends-on" commit, but in the past we have
> reverted it:
>
> https://lore.kernel.org/lkml/20180427135732.999030511@linuxfoundation.org/
Yes, as the commit says that we have a lot of dependencies.
> So I didn't do anything with this patch for <=4.14.
So far so good, thanks!
P.S. In case we need it in the future, we will prepare a backport patch
ourselves.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-11-12 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 5:59 FAILED: patch "[PATCH] pinctrl: intel: Avoid potential glitches if pin is in GPIO" failed to apply to 4.19-stable tree gregkh
2019-11-11 13:19 ` Sasha Levin
2019-11-12 9:11 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112091133.GQ32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=malin.jonsson@ericsson.com \
--cc=mika.westerberg@linux.intel.com \
--cc=oliver.barta@aptiv.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).