From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E0CC432C3 for ; Sat, 16 Nov 2019 16:04:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D34C21823 for ; Sat, 16 Nov 2019 16:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573920271; bh=pz831w1FYuAKytC2tJGnO7bVucvEVuEDHUgUhpkzv/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OXzkI9xZNz2Ufxbgt9odRUuJmssnQwclDlwtIlG4TAYSaXyX/ywrvyFX1JKN7oOq4 efWdrb87tbZtdijcjoy6FNxFk2RAzSwnUgNv7kakjcTUclYtWn+PcuKTvIvOk9B7U0 /QErWvx4bJm5ir6HbaVU9R7C8i8omjEMTNuTDLbA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730242AbfKPQE0 (ORCPT ); Sat, 16 Nov 2019 11:04:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:60566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728857AbfKPPvp (ORCPT ); Sat, 16 Nov 2019 10:51:45 -0500 Received: from sasha-vm.mshome.net (unknown [50.234.116.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7441621906; Sat, 16 Nov 2019 15:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573919504; bh=pz831w1FYuAKytC2tJGnO7bVucvEVuEDHUgUhpkzv/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PyPyYJU5hbfrSDlY6qK5QeqrWxVWA9LoVXFYGNFcu+NGyJjc/FLP8XR45K9ndjSTl aQiwGHvI0vxivBDhDCL1CBHdqN/xAMponn6Do50Fui+RSmvxfCLcfvH6IPQFi9sey6 a9edHqQakSEOX2M/ToPFh+YsXn9a+bcqYlJlvzZQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Philipp Klocke , Takashi Iwai , Sasha Levin , clang-built-linux@googlegroups.com Subject: [PATCH AUTOSEL 4.9 29/99] ALSA: i2c/cs8427: Fix int to char conversion Date: Sat, 16 Nov 2019 10:49:52 -0500 Message-Id: <20191116155103.10971-29-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191116155103.10971-1-sashal@kernel.org> References: <20191116155103.10971-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Philipp Klocke [ Upstream commit eb7ebfa3c1989aa8e59d5e68ab3cddd7df1bfb27 ] Compiling with clang yields the following warning: sound/i2c/cs8427.c:140:31: warning: implicit conversion from 'int' to 'char' changes value from 160 to -96 [-Wconstant-conversion] data[0] = CS8427_REG_AUTOINC | CS8427_REG_CORU_DATABUF; ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ Because CS8427_REG_AUTOINC is defined as 128, it is too big for a char field. So change data from char to unsigned char, that it can hold the value. This patch does not change the generated code. Signed-off-by: Philipp Klocke Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/i2c/cs8427.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c index 7e21621e492a4..7fd1b40008838 100644 --- a/sound/i2c/cs8427.c +++ b/sound/i2c/cs8427.c @@ -118,7 +118,7 @@ static int snd_cs8427_send_corudata(struct snd_i2c_device *device, struct cs8427 *chip = device->private_data; char *hw_data = udata ? chip->playback.hw_udata : chip->playback.hw_status; - char data[32]; + unsigned char data[32]; int err, idx; if (!memcmp(hw_data, ndata, count)) -- 2.20.1