From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 375C9C432C0 for ; Tue, 19 Nov 2019 20:40:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B32622460 for ; Tue, 19 Nov 2019 20:40:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aJYoIoZo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726722AbfKSUkx (ORCPT ); Tue, 19 Nov 2019 15:40:53 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46468 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbfKSUkx (ORCPT ); Tue, 19 Nov 2019 15:40:53 -0500 Received: by mail-pl1-f193.google.com with SMTP id l4so12456912plt.13; Tue, 19 Nov 2019 12:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CSaSjdFx+v8TgqrKNkfnWp7nAv6SAOOTZ17l4vlUo0A=; b=aJYoIoZo4QrycytU5Yl3xmbMDv1vOxs2Mh3otchnoI4oDPu8VAJgOdYhgnq2GH0N2o uALAu4Z1r142+V8LFJ2vOm0bxbtBbpR3BNFH8BdExAK1d/736Cm7OIBw8dBwLzb2eQCp nrnnaEpSJD3lq0FWy+1Li3bq6wStpqGL9xbQG1so/goyttNLtjo5wO02/XhueNG9H7bY jfIpVYgHKcKNnOe0KSCBN+wWOyFlWoL08SkUPvAv7R16DY7RKc0sqAB7+r0BBEW22uR0 YGJPINP3M1FEkycEwKf4hYizyRn418KRHU6LyPFdBSGkS97gKXxZLuWwj6Ts5uIlsCN+ l83A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=CSaSjdFx+v8TgqrKNkfnWp7nAv6SAOOTZ17l4vlUo0A=; b=DmJcX6btwKKEDmwVSsdLAhtmnH71mF+I0MczOOxmPe2KfUqaKMGDTWsZaR5hxvM2Ci NXZIP+xGvi2h9ryftksszEkZB7kmaDxiseGHm8EQYwFEb8Ul6m690il9huP1+aSQ3oGm P0DHkHxici1cAXssYgzGhHUm1IBwyihQMiwTbKdgPgNFowBSzSg3lQhskNcVPJFNO53h 3BTVvVNn1PR08wqYXvVe7K0hBoAdk2RWYz1itPX/fXmDV2dbzSLZ8mkghkjT/C2ZoQXS J7u81UZUqKFn8vrgRir6yyKmHDbCm7Wq8itgfsshsi/DO2gBqnV4nSwLAXixIsmFVViN msxQ== X-Gm-Message-State: APjAAAUE7SuwWZpQ74X5pXumxZFUl7747Hy6+hFntAXEbpXpn64Up5R0 Id39rC4OLZqCcw+WxAmLP18aSEyX X-Google-Smtp-Source: APXvYqz5aaftKLhMq3XwHsDL6DPu4M/T0DcRhsAeCdvGD/dzTZxwJuRAZb2EaSKvm4fsVHhq6RqKpA== X-Received: by 2002:a17:90a:326b:: with SMTP id k98mr8957149pjb.50.1574196051134; Tue, 19 Nov 2019 12:40:51 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id a6sm24793197pgc.4.2019.11.19.12.40.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Nov 2019 12:40:50 -0800 (PST) Date: Tue, 19 Nov 2019 12:40:49 -0800 From: Guenter Roeck To: Ben Hutchings Cc: Miguel Ojeda , linux-kernel , stable@vger.kernel.org, Linus Torvalds , Andrew Morton , Denis Kirjanov Subject: Re: [PATCH 3.16 000/132] 3.16.74-rc1 review Message-ID: <20191119204049.GD14938@roeck-us.net> References: <20190920200423.GA26056@roeck-us.net> <8dbced01558cd8d4a1d4f058010e7d63e5f6810e.camel@decadent.org.uk> <13b0e0ced6e9420dc91242dbe85cdf96c06fb645.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13b0e0ced6e9420dc91242dbe85cdf96c06fb645.camel@decadent.org.uk> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Nov 19, 2019 at 02:58:58PM +0000, Ben Hutchings wrote: > On Sun, 2019-09-22 at 21:26 +0200, Miguel Ojeda wrote: > > On Sun, Sep 22, 2019 at 9:04 PM Ben Hutchings wrote: > > > It looks like this is triggered by you switching arm builds from gcc 8 > > > to 9, rather than by any code change. > > > > > > Does it actually make sense to try to support building Linux 3.16 with > > > gcc 9? If so, I suppose I'll need to add: > > > > > > commit edc966de8725f9186cc9358214da89d335f0e0bd > > > Author: Miguel Ojeda > > > Date: Fri Aug 2 12:37:56 2019 +0200 > > > > > > Backport minimal compiler_attributes.h to support GCC 9 > > > > > > commit a6e60d84989fa0e91db7f236eda40453b0e44afa > > > Author: Miguel Ojeda > > > Date: Sat Jan 19 20:59:34 2019 +0100 > > > > > > include/linux/module.h: copy __init/__exit attrs to init/cleanup_module > > > > Yeah, those should fix it. > > A week or two back I tried building 3.16 for x86_64 with gcc 8, which > produced some warnings but did succeed (and I know Guenter successfully > build-tests 3.16 with gcc 8 for many architectures). However, the > kernel didn't boot on a test system, while the same code built with gcc > 4.9 (if I remember correctly) did boot. > > While I'm not about to remove support for gcc 8, this makes me think > that there are some not-so-obvious fixes required to make 3.16 properly > compatible with recent gcc versions. So I would rather not continue > adding superficial support for them, that may lead to people wasting > time building broken kernels. > I kind of agree. It would make my life easier since I'd be able to drop older compilers, but on the other side anyone actually using 3.16 kernels will very likely not update their compilers for the same reason they don't update the kernel. Guenter