From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF96C432C0 for ; Fri, 22 Nov 2019 06:22:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06B442070A for ; Fri, 22 Nov 2019 06:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574403759; bh=mU2WWZMRT10ZM1zqwCE1vSAm0rosjGx9eVwJBKpUqIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XmkOvUvQp4D4DYyA2QFQit+a9m+uYzZxJ+k3FdEB5MCmnNo6AOPWfbkrgSn0sn8ZU /Q7abp0Yudh7mNtdmN7kwUgrwvM9jgKktQfgG2xw+DJ9sm2j80DnlqjOTjFkY7Tkz0 byVLVwhW7dHfuF1h2PgTiueWhDqgr5gte0UclNQA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbfKVGWd (ORCPT ); Fri, 22 Nov 2019 01:22:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:57322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728355AbfKVFv6 (ORCPT ); Fri, 22 Nov 2019 00:51:58 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 72A742070A; Fri, 22 Nov 2019 05:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574401918; bh=mU2WWZMRT10ZM1zqwCE1vSAm0rosjGx9eVwJBKpUqIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DkHs3WxWnfGXJlI9iR6rwnP1A6y4Ms0hy0O9RAf/KYhaFQcnd7GwEp3X7qy+6AUWY 0bdObgvbna8Gbvd0Fywjsc8U9zGRjrH3OZW6mmmtzQRjMM6CC8EBlLsN6qGh1UQoD+ bMtmOmTP3Z8j850rqB2mI7AlMdyANicYpphNKWeY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kangjie Lu , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 148/219] atl1e: checking the status of atl1e_write_phy_reg Date: Fri, 22 Nov 2019 00:48:00 -0500 Message-Id: <20191122054911.1750-141-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122054911.1750-1-sashal@kernel.org> References: <20191122054911.1750-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kangjie Lu [ Upstream commit ff07d48d7bc0974d4f96a85a4df14564fb09f1ef ] atl1e_write_phy_reg() could fail. The fix issues an error message when it fails. Signed-off-by: Kangjie Lu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c index 9dc6da039a6d9..3164aad29bcf8 100644 --- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c @@ -473,7 +473,9 @@ static void atl1e_mdio_write(struct net_device *netdev, int phy_id, { struct atl1e_adapter *adapter = netdev_priv(netdev); - atl1e_write_phy_reg(&adapter->hw, reg_num & MDIO_REG_ADDR_MASK, val); + if (atl1e_write_phy_reg(&adapter->hw, + reg_num & MDIO_REG_ADDR_MASK, val)) + netdev_err(netdev, "write phy register failed\n"); } static int atl1e_mii_ioctl(struct net_device *netdev, -- 2.20.1