From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 140B7C43215 for ; Fri, 22 Nov 2019 05:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0CF72070A for ; Fri, 22 Nov 2019 05:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574401940; bh=xsYVwr7Zh3Sl5HxMv2r9Twf7jo7heLrCDCLKr2yFn9o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xJMbRpCVIgvCfH+UWUdrIT4pGMqpN3KjC0Y+2JgQ2PjzUKLblwo35BMlXKNL1qonv Fag9qBqO9VJoo7uNff/y4DXiTsT8RqR4PvKbPCx+9K6lWI9Z5HpkGcCdogqbR9EEjh jf90ZE6TYFt+HSBS9Hl+7Uww4iOjyheC4jotN97c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728494AbfKVFwT (ORCPT ); Fri, 22 Nov 2019 00:52:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:57890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728476AbfKVFwQ (ORCPT ); Fri, 22 Nov 2019 00:52:16 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20C06207FA; Fri, 22 Nov 2019 05:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574401935; bh=xsYVwr7Zh3Sl5HxMv2r9Twf7jo7heLrCDCLKr2yFn9o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n0bbD+1Ah+xdN/HGbs77sx2+4B9RetWPdHYZUl0nFz7+G5O4TDz4M4R+9M3VVIISW Z89sznquYe17Dx5a3Dj9pT0u4ryIX/VdX8vU0Y4JNQZBw3USSatOKiyzQ0HpfCFsiz 5GvUq02yxXIxwL0ioLV3pGV0QNw+CZQHj3w6gBY0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aditya Pakki , Michal Kalderon , Jason Gunthorpe , Sasha Levin , linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 161/219] infiniband/qedr: Potential null ptr dereference of qp Date: Fri, 22 Nov 2019 00:48:13 -0500 Message-Id: <20191122054911.1750-154-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122054911.1750-1-sashal@kernel.org> References: <20191122054911.1750-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Aditya Pakki [ Upstream commit 9c6260de505b63638dd86fcc33849b17f6146d94 ] idr_find() may fail and return a NULL pointer. The fix checks the return value of the function and returns an error in case of NULL. Signed-off-by: Aditya Pakki Acked-by: Michal Kalderon Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/qedr/qedr_iw_cm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/qedr/qedr_iw_cm.c b/drivers/infiniband/hw/qedr/qedr_iw_cm.c index 505fa36487629..93b16237b7677 100644 --- a/drivers/infiniband/hw/qedr/qedr_iw_cm.c +++ b/drivers/infiniband/hw/qedr/qedr_iw_cm.c @@ -492,6 +492,8 @@ int qedr_iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) int i; qp = idr_find(&dev->qpidr.idr, conn_param->qpn); + if (unlikely(!qp)) + return -EINVAL; laddr = (struct sockaddr_in *)&cm_id->m_local_addr; raddr = (struct sockaddr_in *)&cm_id->m_remote_addr; -- 2.20.1