From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F68C432C0 for ; Fri, 22 Nov 2019 06:29:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D98D320674 for ; Fri, 22 Nov 2019 06:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574404152; bh=nqrDeAiqwjw67y0i2EHRlzpeX2mJIKdZBClni9COesA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TBAYNKAqQbb492jp/AQMztbsHnaKkDwoYysbhPCKmFtz+x9hn9Xj8MnPdrsqHfkvs 5d+raUpeM0bbCU7kTMV4LmYfoM55kdYBcWDWoNQ1NU3BWaOqmorPeTprQufOzOi0Bg KmrUQm9ypBijOoD7xX6wPj/ab/YO2LU5OiYkEN2E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727320AbfKVG3E (ORCPT ); Fri, 22 Nov 2019 01:29:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:54440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727478AbfKVFuD (ORCPT ); Fri, 22 Nov 2019 00:50:03 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FB302068F; Fri, 22 Nov 2019 05:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574401803; bh=nqrDeAiqwjw67y0i2EHRlzpeX2mJIKdZBClni9COesA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NSFVJRX71g5LwIGECMJvZhNQreD3ZGPE2X8iVfN0XXgUuO8Ik+u8oQNzsf+Dep4i1 AHTEG38rjtyfcq1q3VvwvF1PNib/GQ09PO0EsN6qw+wIamCXWzBWtNjMPIaloUAXub +j8UGwSw5OOgI4v8rMi6nY17Q6yQIrMO6zpw3OoU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pan Bian , Larry Finger , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 048/219] rtl818x: fix potential use after free Date: Fri, 22 Nov 2019 00:46:20 -0500 Message-Id: <20191122054911.1750-41-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122054911.1750-1-sashal@kernel.org> References: <20191122054911.1750-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Pan Bian [ Upstream commit afbb1947db94eacc5a13302eee88a9772fb78935 ] entry is released via usb_put_urb just after calling usb_submit_urb. However, entry is used if the submission fails, resulting in a use after free bug. The patch fixes this. Signed-off-by: Pan Bian ACKed-by: Larry Finger Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c index 9a1d15b3ce453..518caaaf8a987 100644 --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c @@ -444,12 +444,13 @@ static int rtl8187_init_urbs(struct ieee80211_hw *dev) skb_queue_tail(&priv->rx_queue, skb); usb_anchor_urb(entry, &priv->anchored); ret = usb_submit_urb(entry, GFP_KERNEL); - usb_put_urb(entry); if (ret) { skb_unlink(skb, &priv->rx_queue); usb_unanchor_urb(entry); + usb_put_urb(entry); goto err; } + usb_put_urb(entry); } return ret; -- 2.20.1