Stable Archive on
 help / color / Atom feed
From: "Theodore Y. Ts'o" <>
To: Jan Kara <>
Subject: Re: [PATCH] ext4: Fix ext4_empty_dir() for directories with holes
Date: Wed, 27 Nov 2019 15:00:15 -0500
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Nov 27, 2019 at 02:12:58PM +0100, Jan Kara wrote:
> Function ext4_empty_dir() doesn't correctly handle directories with
> holes and crashes on bh->b_data dereference when bh is NULL. Reorganize
> the loop to use 'offset' variable all the times instead of comparing
> pointers to current direntry with bh->b_data pointer. Also add more
> strict checking of '.' and '..' directory entries to avoid entering loop
> in possibly invalid state on corrupted filesystems.
> References: CVE-2019-19037
> CC:
> Fixes: 4e19d6b65fb4 ("ext4: allow directory holes")
> Signed-off-by: Jan Kara <>

Thanks, applied.

					- Ted

  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 13:12 Jan Kara
2019-11-27 19:44 ` Theodore Y. Ts'o
2019-11-27 19:53   ` Theodore Y. Ts'o
2019-11-27 20:00 ` Theodore Y. Ts'o [this message]
2019-12-01 15:13 ` [ext4] 3d487697d2: BUG:unable_to_handle_page_fault_for_address kernel test robot
2019-12-02 11:34   ` Jan Kara

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Stable Archive on

Archives are clonable:
	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone