From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1180C43215 for ; Wed, 27 Nov 2019 21:30:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7782220665 for ; Wed, 27 Nov 2019 21:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574890212; bh=uWZClTrsqmEFx8byq1mK09fgpItzYGHhc8KLTIkX/1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iHbJvASw5aj72C8bGJdB2us/3vMqTrnskNQUTp/QDyhH6DHyExsHg4bP8b9DGHjSQ J9amG5imVt5zmBXahqAWMaX5PBTQtDnwsmw/so1qUafvg8TklsQTCAbDHRzRnuoHzJ 7dFVLelzipdaDd1GfA6YE6s5Wc0O4QRQX6Y7twuM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731118AbfK0VaH (ORCPT ); Wed, 27 Nov 2019 16:30:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:46924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728364AbfK0U4K (ORCPT ); Wed, 27 Nov 2019 15:56:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75D3A20862; Wed, 27 Nov 2019 20:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888169; bh=uWZClTrsqmEFx8byq1mK09fgpItzYGHhc8KLTIkX/1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iYuCcnuBT+ZdvSluclMPXbfewTaD4yXupsNjbhDC2ciMrUQ+dsxlbUSTHNGt808CA l2yTTj6LGaCl6Fswl8E1biSg+t9g3EV1nBZ2/DFHdqtmwC88PyzciWOyqSadXkb73H xoMj+Oe4gyuZ2bPO1Xid50MS7uw61CNCaCORcO2s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Geoff Levand , Michael Ellerman , Sasha Levin Subject: [PATCH 4.19 031/306] powerpc: Fix signedness bug in update_flash_db() Date: Wed, 27 Nov 2019 21:28:01 +0100 Message-Id: <20191127203117.022103888@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203114.766709977@linuxfoundation.org> References: <20191127203114.766709977@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 014704e6f54189a203cc14c7c0bb411b940241bc ] The "count < sizeof(struct os_area_db)" comparison is type promoted to size_t so negative values of "count" are treated as very high values and we accidentally return success instead of a negative error code. This doesn't really change runtime much but it fixes a static checker warning. Signed-off-by: Dan Carpenter Acked-by: Geoff Levand Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin --- arch/powerpc/platforms/ps3/os-area.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/ps3/os-area.c b/arch/powerpc/platforms/ps3/os-area.c index cdbfc5cfd6f38..f5387ad822798 100644 --- a/arch/powerpc/platforms/ps3/os-area.c +++ b/arch/powerpc/platforms/ps3/os-area.c @@ -664,7 +664,7 @@ static int update_flash_db(void) db_set_64(db, &os_area_db_id_rtc_diff, saved_params.rtc_diff); count = os_area_flash_write(db, sizeof(struct os_area_db), pos); - if (count < sizeof(struct os_area_db)) { + if (count < 0 || count < sizeof(struct os_area_db)) { pr_debug("%s: os_area_flash_write failed %zd\n", __func__, count); error = count < 0 ? count : -EIO; -- 2.20.1