From: Lee Jones <lee.jones@linaro.org>
To: stable@vger.kernel.org
Subject: [PATCH 4.19 14/15] mtd: spi-nor: cast to u64 to avoid uint overflows
Date: Mon, 2 Dec 2019 10:30:49 +0000 [thread overview]
Message-ID: <20191202103050.2668-14-lee.jones@linaro.org> (raw)
In-Reply-To: <20191202103050.2668-1-lee.jones@linaro.org>
From: "huijin.park" <huijin.park@samsung.com>
[ Upstream commit 84a1c2109d23df3543d96231c4fee1757299bb1a ]
The "params->size" is defined as "u64".
And "info->sector_size" and "info->n_sectors" are defined as
unsigned int and u16.
Thus, u64 data might have strange data(loss data) if the result
overflows an unsigned int.
This patch casts "info->sector_size" to an u64.
Signed-off-by: huijin.park <huijin.park@samsung.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index f028277fb1ce..2e183425facd 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -2459,7 +2459,7 @@ static int spi_nor_init_params(struct spi_nor *nor,
memset(params, 0, sizeof(*params));
/* Set SPI NOR sizes. */
- params->size = info->sector_size * info->n_sectors;
+ params->size = (u64)info->sector_size * info->n_sectors;
params->page_size = info->page_size;
/* (Fast) Read settings. */
--
2.24.0
next prev parent reply other threads:[~2019-12-02 10:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 10:30 [PATCH 4.19 01/15] clk: at91: fix update bit maps on CFG_MOR write Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 02/15] arm: add missing include platform-data/atmel.h Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 03/15] watchdog: sama5d4: fix WDD value to be always set to max Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 04/15] drm/atmel-hlcdc: revert shift by 8 Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 05/15] net: macb: Fix SUBNS increment and increase resolution Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 06/15] media: v4l2-ctrl: fix flags for DO_WHITE_BALANCE Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 07/15] net: macb: fix error format in dev_err() Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 08/15] media: atmel: atmel-isc: fix asd memory allocation Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 09/15] media: atmel: atmel-isc: fix INIT_WORK misplacement Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 10/15] mtd: rawnand: atmel: Fix spelling mistake in error message Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 11/15] pwm: Clear chip_data in pwm_put() Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 12/15] net: macb driver, check for SKBTX_HW_TSTAMP Lee Jones
2019-12-02 10:30 ` [PATCH 4.19 13/15] mtd: rawnand: atmel: fix possible object reference leak Lee Jones
2019-12-02 10:30 ` Lee Jones [this message]
2019-12-02 10:30 ` [PATCH 4.19 15/15] clk: at91: generated: set audio_pll_allowed in at91_clk_register_generated() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202103050.2668-14-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).