From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B2DAC432C0 for ; Tue, 3 Dec 2019 19:17:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E0822080F for ; Tue, 3 Dec 2019 19:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575400620; bh=RwkH1ulrDvXWwzr0DH2in8vnq4W1hdcqSlSTktOsmNc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zAJPcZDSkgPZ117SzltziKHzCEYrzVyQLBk3Tp6lKsgIc0a6L4yCqTTiA04ZQA7JA I/RJLXynU0GMXeyob2SYy5dt4WbbVQjmalXTCJWGuLLXc9O4cvYv4OFebDC3OSNIYs CBb7Z4Uze335nOzDF9w3tynzkf3ABGE31uHQOUkg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726995AbfLCTRA (ORCPT ); Tue, 3 Dec 2019 14:17:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:58458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfLCTQ7 (ORCPT ); Tue, 3 Dec 2019 14:16:59 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 43F5D20803; Tue, 3 Dec 2019 19:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575400617; bh=RwkH1ulrDvXWwzr0DH2in8vnq4W1hdcqSlSTktOsmNc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IzLA9b69IyyKmXf2EXkqbAryRlspPIP5VjeAoyBOihZMSOcXm+XynlTzth95G6uek gkaOC+z46RheKclf3vLkhThYMZ8sil0fhwSsVi2JEUqNF/HR+5ey4D3GE/CYSkevZP Bj/Sy0bDVEI9pv3r5OFVopvLNm17rlK9I/1wzLBo= Date: Tue, 3 Dec 2019 20:16:55 +0100 From: Greg Kroah-Hartman To: Paolo Bonzini Cc: Jack Wang , linux-kernel@vger.kernel.org, stable , Sean Christopherson , Jim Mattson , Sasha Levin Subject: Re: [PATCH 4.19 067/306] KVM: nVMX: move check_vmentry_postreqs() call to nested_vmx_enter_non_root_mode() Message-ID: <20191203191655.GC2734645@kroah.com> References: <20191127203114.766709977@linuxfoundation.org> <20191127203119.676489279@linuxfoundation.org> <20191202145105.GA571975@kroah.com> <828cf8b7-11ac-e707-57b6-cb598cc37f1b@redhat.com> <1387d9b8-0e08-a22e-6dd1-4b7ea58567b3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387d9b8-0e08-a22e-6dd1-4b7ea58567b3@redhat.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Dec 03, 2019 at 01:52:47PM +0100, Paolo Bonzini wrote: > On 03/12/19 13:27, Jack Wang wrote: > >>> Should we simply revert the patch, maybe also > >>> 9fe573d539a8 ("KVM: nVMX: reset cache/shadows when switching loaded VMCS") > >>> > >>> Both of them are from one big patchset: > >>> https://patchwork.kernel.org/cover/10616179/ > >>> > >>> Revert both patches recover the regression I see on kvm-unit-tests. > >> Greg already included the patches that the bot missed, so it's okay. > >> > >> Paolo > >> > > Sorry, I think I gave wrong information initially, it's 9fe573d539a8 > > ("KVM: nVMX: reset cache/shadows when switching loaded VMCS") > > which caused regression. > > > > Should we revert or there's following up fix we should backport? > > Hmm, let's revert all four. This one, the two follow-ups and 9fe573d539a8. 4? I see three patches here, the 2 follow-up patches that I applied to the queue, and the "original" backport of b7031fd40fcc ("KVM: nVMX: reset cache/shadows when switching loaded VMCS") which showed up in the 4.14.157 and 4.19.87 kernels. confused, greg k-h