From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 327A2C43215 for ; Tue, 3 Dec 2019 23:05:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC00B20656 for ; Tue, 3 Dec 2019 23:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575414349; bh=oRalRQLcvw3mDLy4hoii35OLsY/POsYuwsyEtYJ06wQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cb/Pwmp8ih9NPp50ZcpB8TBQo5MnTJEjADxxThqaFYU4vRLMwfGqe4e+AqG/sLYud vbZydx3wVnPHk6lJKi9FqZo62HvjlzZXSELmio1+oRfUizmOWd/ZIjFrlYKZ6l5wIR /sNnC3lRvvLFb3ZBcKath28qmXKfNWoAPd0ct0z0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729420AbfLCWty (ORCPT ); Tue, 3 Dec 2019 17:49:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:41136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729676AbfLCWtw (ORCPT ); Tue, 3 Dec 2019 17:49:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0EDC22084B; Tue, 3 Dec 2019 22:49:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413391; bh=oRalRQLcvw3mDLy4hoii35OLsY/POsYuwsyEtYJ06wQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mhXxfRB49bTNn+mQ8cLMCuV//gZ+641UGPoikvW39BEO0e2bOVImc0UwRaE/KzEfw HU5BKNGGlQLcgnArXMSfbTo3ahwsiogj1HfcDuN0ra6vb1QlDYJzJpWG+B+tMXBFUg ex93bbjkZWXDxIcVYw52GNYwpUa1pqhESuMOIAdk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Linus Walleij , Sasha Levin Subject: [PATCH 4.19 110/321] gpiolib: Fix return value of gpio_to_desc() stub if !GPIOLIB Date: Tue, 3 Dec 2019 23:32:56 +0100 Message-Id: <20191203223432.875862512@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit c5510b8dafce5f3f5a039c9b262ebcae0092c462 ] If CONFIG_GPOILIB is not set, the stub of gpio_to_desc() should return the same type of error as regular version: NULL. All the callers compare the return value of gpio_to_desc() against NULL, so returned ERR_PTR would be treated as non-error case leading to dereferencing of error value. Fixes: 79a9becda894 ("gpiolib: export descriptor-based GPIO interface") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- include/linux/gpio/consumer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index 412098b24f58b..8dfd8300d9c31 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -475,7 +475,7 @@ static inline int gpiod_set_consumer_name(struct gpio_desc *desc, static inline struct gpio_desc *gpio_to_desc(unsigned gpio) { - return ERR_PTR(-EINVAL); + return NULL; } static inline int desc_to_gpio(const struct gpio_desc *desc) -- 2.20.1