From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3651FC2D0C6 for ; Wed, 11 Dec 2019 23:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D29D2173E for ; Wed, 11 Dec 2019 23:26:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QGLnf6IY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727119AbfLKX0w (ORCPT ); Wed, 11 Dec 2019 18:26:52 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:60688 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726987AbfLKX0w (ORCPT ); Wed, 11 Dec 2019 18:26:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576106810; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=xIBtoo8ZOmm+jwrAM70WjwrXU/X7efOhZSB/CmsOthA=; b=QGLnf6IYe3jdAqEtWNWEgM5ymUBRg6f4T4kK0ZR6k1al9sE1Oyv2iMD1favraK8MD/Xlqk RZB+iizej4UVYLn1TaMsvYbRRMF8jvqLwb6LL3dVvnmM+W0kCQe2PYPuPTTqzzQqo7+frN zOc0oeZC2OUh6zrwVRvYgyQhJtiAztw= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-MgCzO3_QPcO6jwCxsjaHyg-1; Wed, 11 Dec 2019 18:26:49 -0500 X-MC-Unique: MgCzO3_QPcO6jwCxsjaHyg-1 Received: by mail-pl1-f198.google.com with SMTP id b8so262355plz.12 for ; Wed, 11 Dec 2019 15:26:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=xIBtoo8ZOmm+jwrAM70WjwrXU/X7efOhZSB/CmsOthA=; b=Sm3n5rn5F6HoEo4hXf5qsKr3CdGnPrHcyJmRRPiuxFBpAafR9Ozb82OLBF5GzQryc6 tgSbzMWfARh6DCQhN2dmePiCUP6VK7ELTMnAnqqVvbJcFUXTT0nDCpbSY+9UjEeWshTh Z1IPkF58S+R76ixsxWoxd466C+cNMcpcHoSB8Vwh44pNos1TfdBVBGRv0z9paOgf2UAh XEgnTgsSYPlqVxEF694rtrkfOLMCVXaWvK6NeHBB4ibMPnkvvCXagVoiL/DboZZuyRi2 vSxMEYhQJtcryHEmI1QZpPhjtjyQHwJJ/NpMi2u9UykB4qLr5EECieWeD9YHXjPDZ4aw h7vw== X-Gm-Message-State: APjAAAWG5nv49eeSyiW3xPdSVebZaYx2sdAUL/l9kfUVyjUw1ZiDOMSY IOkyyNRpMVeDG9DUZxK1yckLYfZ0gtNmTxkm9bq5+kOvMoJES2sYw3LC5DRnNobgOnhPMZu3kGW 36F8hqRAEQLJwl8H+ X-Received: by 2002:a17:902:59da:: with SMTP id d26mr6164078plj.287.1576106808651; Wed, 11 Dec 2019 15:26:48 -0800 (PST) X-Google-Smtp-Source: APXvYqxqBrhVo8B0NkfhTA7qmWNMDe2NS+bkpJjXqPqOxnEvLKUmHEM6HPU81t6PZa+dDB2P6rEGHg== X-Received: by 2002:a17:902:59da:: with SMTP id d26mr6164051plj.287.1576106808281; Wed, 11 Dec 2019 15:26:48 -0800 (PST) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id r62sm4469451pfc.89.2019.12.11.15.26.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 15:26:47 -0800 (PST) Date: Wed, 11 Dec 2019 16:26:12 -0700 From: Jerry Snitselaar To: linux-kernel@vger.kernel.org Cc: Christian Bundy , Dan Williams , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Stefan Berger , stable@vger.kernel.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core_init Message-ID: <20191211232612.miaizaxxikhlgvfj@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: linux-kernel@vger.kernel.org, Christian Bundy , Dan Williams , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Stefan Berger , stable@vger.kernel.org, linux-integrity@vger.kernel.org References: <20191211231758.22263-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20191211231758.22263-1-jsnitsel@redhat.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed Dec 11 19, Jerry Snitselaar wrote: >Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when >issuing commands to the tpm during initialization, just reserve the >chip after wait_startup, and release it when we are ready to call >tpm_chip_register. > >Cc: Christian Bundy >Cc: Dan Williams >Cc: Peter Huewe >Cc: Jarkko Sakkinen >Cc: Jason Gunthorpe >Cc: Stefan Berger >Cc: stable@vger.kernel.org >Cc: linux-intergrity@vger.kernel.org Typo on the list address, do you want me to resend Jarkko? >Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") >Signed-off-by: Jerry Snitselaar >--- I did some initial testing with both a 1.2 device and a 2.0 device here. Christian, can you verify that this still solves your timeouts problem you were seeing? Dan, can you try this on the internal system with the interrupt issues? I will see if I can get the t490s owner to run it as well. Thanks, Jerry