From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2861C2D0C3 for ; Mon, 16 Dec 2019 18:28:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AD0C206EC for ; Mon, 16 Dec 2019 18:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576520915; bh=RSPLxhE/wTcEixncolWdp54ohsVgJgKuO//LWMrBKAU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qxrfLExCO5uSD7csNOnzlbe4XAyLkuYe+1U1pM6peC+uSZFUY/PI0L44aUpT1hzSh HIAwwMc9bnJrmbkcfE3bbARDdjeh9np0qmYNXsNbJHxVIKGYTUQ07n3NXc9Q7C0QyH hthNkebSnhQ2qktqCx8NcZYRA30pUovJUEx8Fgpc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731266AbfLPSOp (ORCPT ); Mon, 16 Dec 2019 13:14:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:34516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731114AbfLPSOo (ORCPT ); Mon, 16 Dec 2019 13:14:44 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BCFE20674; Mon, 16 Dec 2019 18:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576520084; bh=RSPLxhE/wTcEixncolWdp54ohsVgJgKuO//LWMrBKAU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lf2VMnRjzgD3wxn0FBHW4pJC6l1bELa6e+AwwHeTtHKvAgbxlcwTlNHMghZbRotfx SBr7V810FqWFsHU40+IKU98AugJUm5AQCRQZGegd8cn2Epnr8S4CISV6VlKOSTfCE1 PSv7Id+rBuf3COwS49G8VWSjjncKpE5vyoYVtDkQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Ewan D. Milne" , Arun Easi , Himanshu Madhani , "Martin K. Petersen" Subject: [PATCH 5.4 010/177] scsi: qla2xxx: Fix memory leak when sending I/O fails Date: Mon, 16 Dec 2019 18:47:46 +0100 Message-Id: <20191216174813.447900095@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174811.158424118@linuxfoundation.org> References: <20191216174811.158424118@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arun Easi commit 2f856d4e8c23f5ad5221f8da4a2f22d090627f19 upstream. On heavy loads, a memory leak of the srb_t structure is observed. This would make the qla2xxx_srbs cache gobble up memory. Fixes: 219d27d7147e0 ("scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands") Cc: stable@vger.kernel.org # 5.2 Link: https://lore.kernel.org/r/20191105150657.8092-7-hmadhani@marvell.com Reviewed-by: Ewan D. Milne Signed-off-by: Arun Easi Signed-off-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_os.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -909,6 +909,8 @@ qla2xxx_queuecommand(struct Scsi_Host *h qc24_host_busy_free_sp: sp->free(sp); + CMD_SP(cmd) = NULL; + qla2x00_rel_sp(sp); qc24_target_busy: return SCSI_MLQUEUE_TARGET_BUSY; @@ -992,6 +994,8 @@ qla2xxx_mqueuecommand(struct Scsi_Host * qc24_host_busy_free_sp: sp->free(sp); + CMD_SP(cmd) = NULL; + qla2xxx_rel_qpair_sp(sp->qpair, sp); qc24_target_busy: return SCSI_MLQUEUE_TARGET_BUSY;