From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F708C43603 for ; Mon, 16 Dec 2019 18:16:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14378206E0 for ; Mon, 16 Dec 2019 18:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576520211; bh=J9rVZcIibE8KKmf4ktt4ACclYyInwY8C4/rXZDkABj8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=L9VCeTGbXPPf7aUJzXmQfMQ9rdwJ+GGTuaKcNXwh2iy/CBUDCG7U5etpoizwyHEfQ iQ8FDeFeS3cU5pMIdFeLG0yttdLE6CwgORuv55O+jly3Fj4yTusUqsmv34ZdeTxDC/ Jx5UZU+YgLfuFL65hwNKYMy07aOgsgv1dnK8Mg1w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731400AbfLPSQt (ORCPT ); Mon, 16 Dec 2019 13:16:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:39850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731262AbfLPSQs (ORCPT ); Mon, 16 Dec 2019 13:16:48 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D0F4F206E0; Mon, 16 Dec 2019 18:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576520208; bh=J9rVZcIibE8KKmf4ktt4ACclYyInwY8C4/rXZDkABj8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FJgVB5S3dB4SLzDm9e3bT5cb+IY5yUne9XBaswLwR9TstQJQ0NLuTY3ROn1h5/3gQ NhR9hlt/wUcbiXEnyeY307acDGsEj83PHWH/IyL6Le/YXYsMXwOkjrfn8+URY7EY4T uIJYHZeNHGyyKVf2RV2Z9Mrdr+iYhs2IHWLB5RO0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mircea Caprioru , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.4 043/177] iio: adc: ad7124: Enable internal reference Date: Mon, 16 Dec 2019 18:48:19 +0100 Message-Id: <20191216174829.741051988@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174811.158424118@linuxfoundation.org> References: <20191216174811.158424118@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Mircea Caprioru commit 11d7c8d3b1259c303fb52789febed58f0bc35ad1 upstream. When the internal reference was selected by a channel it was not enabled. This patch fixes that and enables it. Fixes: b3af341bbd96 ("iio: adc: Add ad7124 support") Signed-off-by: Mircea Caprioru Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/adc/ad7124.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/drivers/iio/adc/ad7124.c +++ b/drivers/iio/adc/ad7124.c @@ -39,6 +39,8 @@ #define AD7124_STATUS_POR_FLAG_MSK BIT(4) /* AD7124_ADC_CONTROL */ +#define AD7124_ADC_CTRL_REF_EN_MSK BIT(8) +#define AD7124_ADC_CTRL_REF_EN(x) FIELD_PREP(AD7124_ADC_CTRL_REF_EN_MSK, x) #define AD7124_ADC_CTRL_PWR_MSK GENMASK(7, 6) #define AD7124_ADC_CTRL_PWR(x) FIELD_PREP(AD7124_ADC_CTRL_PWR_MSK, x) #define AD7124_ADC_CTRL_MODE_MSK GENMASK(5, 2) @@ -424,7 +426,10 @@ static int ad7124_init_channel_vref(stru break; case AD7124_INT_REF: st->channel_config[channel_number].vref_mv = 2500; - break; + st->adc_control &= ~AD7124_ADC_CTRL_REF_EN_MSK; + st->adc_control |= AD7124_ADC_CTRL_REF_EN(1); + return ad_sd_write_reg(&st->sd, AD7124_ADC_CONTROL, + 2, st->adc_control); default: dev_err(&st->sd.spi->dev, "Invalid reference %d\n", refsel); return -EINVAL;