From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6127C43603 for ; Tue, 17 Dec 2019 11:59:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 798D3207FF for ; Tue, 17 Dec 2019 11:59:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727127AbfLQL7z (ORCPT ); Tue, 17 Dec 2019 06:59:55 -0500 Received: from foss.arm.com ([217.140.110.172]:34678 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726571AbfLQL7z (ORCPT ); Tue, 17 Dec 2019 06:59:55 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81CB631B; Tue, 17 Dec 2019 03:59:54 -0800 (PST) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C62C43F6CF; Tue, 17 Dec 2019 03:59:53 -0800 (PST) Date: Tue, 17 Dec 2019 11:59:52 +0000 From: Andrew Murray To: Yurii Monakov Cc: linux-pci@vger.kernel.org, stable@vger.kernel.org, m-karicheri2@ti.com Subject: Re: [PATCH v2] PCI: keystone: Fix link training retries initiation Message-ID: <20191217115951.GB24359@e119886-lin.cambridge.arm.com> References: <20191217143836.3449cfe2@monakov-y.xu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191217143836.3449cfe2@monakov-y.xu> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Dec 17, 2019 at 02:38:36PM +0300, Yurii Monakov wrote: > ks_pcie_stop_link() function does not clear LTSSM_EN_VAL bit so > link training was not triggered more than once after startup. > In configurations where link can be unstable during early boot, > for example, under low temperature, it will never be established. > > Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver") > Signed-off-by: Yurii Monakov > CC:stable@vger.kernel.org > --- > drivers/pci/controller/dwc/pci-keystone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c > index af677254a072..d4de4f6cff8b 100644 > --- a/drivers/pci/controller/dwc/pci-keystone.c > +++ b/drivers/pci/controller/dwc/pci-keystone.c > @@ -510,7 +510,7 @@ static void ks_pcie_stop_link(struct dw_pcie *pci) > /* Disable Link training */ > val = ks_pcie_app_readl(ks_pcie, CMD_STATUS); > val &= ~LTSSM_EN_VAL; > - ks_pcie_app_writel(ks_pcie, CMD_STATUS, LTSSM_EN_VAL | val); > + ks_pcie_app_writel(ks_pcie, CMD_STATUS, val); Looks great, thanks for respinning this. Acked-by: Andrew Murray Thanks, Andrew Murray > } > > static int ks_pcie_start_link(struct dw_pcie *pci) > -- > 2.17.1