From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ammy Yi <ammy.yi@intel.com>,
stable@vger.kernel.org
Subject: Re: [GIT PULL 4/4] intel_th: msu: Fix window switching without windows
Date: Wed, 18 Dec 2019 10:51:13 +1100 [thread overview]
Message-ID: <20191218105113.21cc94fb@canb.auug.org.au> (raw)
In-Reply-To: <20191217120629.GB3156341@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
Hi Greg,
On Tue, 17 Dec 2019 13:06:29 +0100 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Dec 17, 2019 at 01:55:27PM +0200, Alexander Shishkin wrote:
> > Commit 6cac7866c2741 ("intel_th: msu: Add a sysfs attribute to trigger
> > window switch") adds a NULL pointer dereference in the case when there are
> > no windows allocated:
>
> Commit ids should only be specified in 12 digits, not 13 :)
It is possible that 13 digits may be necessary to be unambiguous within
a git repo. In fact, as we continue with a single git repo (Linus'), at
some point 13 digits will become normal.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-12-17 23:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191217115527.74383-1-alexander.shishkin@linux.intel.com>
2019-12-17 11:55 ` [GIT PULL 1/4] intel_th: pci: Add Comet Lake PCH-V support Alexander Shishkin
2019-12-17 11:55 ` [GIT PULL 2/4] intel_th: pci: Add Elkhart Lake SOC support Alexander Shishkin
2019-12-17 11:55 ` [GIT PULL 3/4] intel_th: Fix freeing IRQs Alexander Shishkin
2019-12-17 11:55 ` [GIT PULL 4/4] intel_th: msu: Fix window switching without windows Alexander Shishkin
2019-12-17 12:06 ` Greg Kroah-Hartman
2019-12-17 23:51 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218105113.21cc94fb@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=alexander.shishkin@linux.intel.com \
--cc=ammy.yi@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).