From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5305EC2D0D1 for ; Sun, 29 Dec 2019 17:35:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D458207FD for ; Sun, 29 Dec 2019 17:35:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640939; bh=ssymBFOqeRPxQ7sSX7Zmtt2Y0cloGLCzXEyuNa3o5cU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RBtUHC5y+lizblWQ7neYAFukMZmpRJYylV0Ivqg25wvNwqfE3LK65UAPnJjU9j7cJ QOctEE+VIxpe5nTaG67GxR2SIycOhwmmgV9cSNA75dx5CzVX+BEbDP499BNmbvrkh6 xuNEMEslEz714FMoprw7L8B1gq+moSYQUTrx6cBM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729905AbfL2Rfh (ORCPT ); Sun, 29 Dec 2019 12:35:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:40148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729890AbfL2Rfh (ORCPT ); Sun, 29 Dec 2019 12:35:37 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 67914207FF; Sun, 29 Dec 2019 17:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640936; bh=ssymBFOqeRPxQ7sSX7Zmtt2Y0cloGLCzXEyuNa3o5cU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aobpxLEirNiji0Sv1KSrc5lN+dNOFO9CtroJH8AS/Yc0uZbB3MAXe11ZcvyPFd3Nh eXCfTGukeMMv5qFaNhcr2M0Tpf56q0torcVrELSBNtcGAsWG7868/k2IyILiyaO9y0 xlwi3ajUaNkQJNGSnb7AuIV+HS2CmPISbbUPBeWE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Charles Keepax , Mark Brown , Sasha Levin Subject: [PATCH 4.19 173/219] ASoC: wm5100: add missed pm_runtime_disable Date: Sun, 29 Dec 2019 18:19:35 +0100 Message-Id: <20191229162535.096646432@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162508.458551679@linuxfoundation.org> References: <20191229162508.458551679@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Chuhong Yuan [ Upstream commit b1176bbb70866f24099cd2720283c7219fb4a81c ] The driver forgets to call pm_runtime_disable in remove and probe failure. Add the calls to fix it. Signed-off-by: Chuhong Yuan Acked-by: Charles Keepax Link: https://lore.kernel.org/r/20191118073707.28298-1-hslester96@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm5100.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index ba89d9d711f7..b793701aafcd 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2620,6 +2620,7 @@ static int wm5100_i2c_probe(struct i2c_client *i2c, return ret; err_reset: + pm_runtime_disable(&i2c->dev); if (i2c->irq) free_irq(i2c->irq, wm5100); wm5100_free_gpio(i2c); @@ -2643,6 +2644,7 @@ static int wm5100_i2c_remove(struct i2c_client *i2c) { struct wm5100_priv *wm5100 = i2c_get_clientdata(i2c); + pm_runtime_disable(&i2c->dev); if (i2c->irq) free_irq(i2c->irq, wm5100); wm5100_free_gpio(i2c); -- 2.20.1