From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F37C33C9E for ; Tue, 7 Jan 2020 21:14:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C3E02072A for ; Tue, 7 Jan 2020 21:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431699; bh=Zc4ApMctl6TyoWZtewkmG80a7vVNS+VEH44ujjNZKgc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mPp0lBbn8+JRyHX5sQHpYJmNb7h2SXwpl7rJJlxtE+ijwewoZgq3QtS7j+JNWrBpH V5h9U/qcN9TXCtkJWFB4aFaiv4HgO300XQZs4TsQnmTiIRCOiY3UWvMwg2TXIJKm+3 Qvo20sDBK8M9yaub5oTW7ivwEz1PzFKDk3/EyZA8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729768AbgAGVOz (ORCPT ); Tue, 7 Jan 2020 16:14:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:33594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729573AbgAGVIv (ORCPT ); Tue, 7 Jan 2020 16:08:51 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4898420678; Tue, 7 Jan 2020 21:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431330; bh=Zc4ApMctl6TyoWZtewkmG80a7vVNS+VEH44ujjNZKgc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dt5IwfPVjHxsHYWppzRGqUNKlgcxLPzObsqS4Co6IlB8ZOm3JotWhLH/f/OJO+ulQ fF8kC3Qt12l3lQmKL313CAAf/Q9ZjLwIlr0habe8OIlXHAG2TodkeAUo3Q6bLrcZey 1BljmzJqXMXLe1KaZZQiNqZ9qbOeOs5ugco1TNHA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhiqiang Liu , Song Liu , Sasha Levin Subject: [PATCH 4.14 13/74] md: raid1: check rdev before reference in raid1_sync_request func Date: Tue, 7 Jan 2020 21:54:38 +0100 Message-Id: <20200107205144.478287924@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205135.369001641@linuxfoundation.org> References: <20200107205135.369001641@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhiqiang Liu [ Upstream commit 028288df635f5a9addd48ac4677b720192747944 ] In raid1_sync_request func, rdev should be checked before reference. Signed-off-by: Zhiqiang Liu Signed-off-by: Song Liu Signed-off-by: Sasha Levin --- drivers/md/raid1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index f46ac9db9edb..0a9d623b13c2 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -2749,7 +2749,7 @@ static sector_t raid1_sync_request(struct mddev *mddev, sector_t sector_nr, write_targets++; } } - if (bio->bi_end_io) { + if (rdev && bio->bi_end_io) { atomic_inc(&rdev->nr_pending); bio->bi_iter.bi_sector = sector_nr + rdev->data_offset; bio_set_dev(bio, rdev->bdev); -- 2.20.1