From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FB67C33CB6 for ; Tue, 14 Jan 2020 10:14:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A155207FF for ; Tue, 14 Jan 2020 10:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996855; bh=N1dZ5j8ezG8ofFzlhREMnbtoxQubWfVwdRTWmdQ3sh4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0aI9V7pakh/zxYI69Gnq7DF9G+fybYtJ7u1/yjZPXncP0sELikKXM7C7pi3FOTT9c NgK+vEzoJ5nGRuz+JC2dDWA4vkLB+b1EyFIZpNDwIc/DOM+oI8W39ZtIs0KTcLrPhf S3JFuE3khi0XX65tJCVWVRI/2oPz0ZO9TOR+awVg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729963AbgANKNH (ORCPT ); Tue, 14 Jan 2020 05:13:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:50144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729728AbgANKNG (ORCPT ); Tue, 14 Jan 2020 05:13:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE03C24679; Tue, 14 Jan 2020 10:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996786; bh=N1dZ5j8ezG8ofFzlhREMnbtoxQubWfVwdRTWmdQ3sh4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hMdj+uxCI/r/aTiGe8XGouO0WiLETp9HTRgUHTEpnP1Uko31qTuXSLQ4vWsAV1XR6 92RU3wQxlQ8iqeXH6UzoWClKjaY/hti1yk2LbrzQXU2xWwdwLZUSX30DuFwl/PC6IX i7txQIHfN4M9CwEPyqYM6tziOk91UI526fPBrFN8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , "Martin K. Petersen" , Ben Hutchings Subject: [PATCH 4.4 24/28] scsi: bfa: release allocated memory in case of error Date: Tue, 14 Jan 2020 11:02:26 +0100 Message-Id: <20200114094344.348278212@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200114094336.845958665@linuxfoundation.org> References: <20200114094336.845958665@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Navid Emamdoost commit 0e62395da2bd5166d7c9e14cbc7503b256a34cb0 upstream. In bfad_im_get_stats if bfa_port_get_stats fails, allocated memory needs to be released. Link: https://lore.kernel.org/r/20190910234417.22151-1-navid.emamdoost@gmail.com Signed-off-by: Navid Emamdoost Signed-off-by: Martin K. Petersen Cc: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/bfa/bfad_attr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/scsi/bfa/bfad_attr.c +++ b/drivers/scsi/bfa/bfad_attr.c @@ -282,8 +282,10 @@ bfad_im_get_stats(struct Scsi_Host *shos rc = bfa_port_get_stats(BFA_FCPORT(&bfad->bfa), fcstats, bfad_hcb_comp, &fcomp); spin_unlock_irqrestore(&bfad->bfad_lock, flags); - if (rc != BFA_STATUS_OK) + if (rc != BFA_STATUS_OK) { + kfree(fcstats); return NULL; + } wait_for_completion(&fcomp.comp);