From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CDD7C33CB2 for ; Tue, 14 Jan 2020 10:15:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D0E424676 for ; Tue, 14 Jan 2020 10:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996949; bh=wZsuNyg52iC6tK/7FHq0jDe5n+VxHjD0GEhVgbuEv9c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TFnSyI3TgQUAMtXk6XdP/0I8TJg8nwhTkbLvPL94R+5p5jcMlfCauiGFyW0lQJ0xm uq5W2Ev+v7QfG06Uvyl5mXNAT823ZPttmuYsMyHbC8eJpqwHk4KWnYoqUfUS1qq6nZ QEm+i0br1j2x6LCHxxqA6R/5WNZnYvQLix3c1G4U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729592AbgANKPo (ORCPT ); Tue, 14 Jan 2020 05:15:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:44990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730909AbgANKKn (ORCPT ); Tue, 14 Jan 2020 05:10:43 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A881320678; Tue, 14 Jan 2020 10:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996643; bh=wZsuNyg52iC6tK/7FHq0jDe5n+VxHjD0GEhVgbuEv9c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ESehhrVIMPXt09BKNr/lsWNNX027YhZ77i+fJssc5mjbuaGYlBvOxvaAv4L4eFd65 THMYwgYJsmmE+p6gleul3BoZKPu5l4xDG9kHEuW41Uwa+N4faqg0WyKw9F75sJ4nZg PAtg+mlVsQRcMMnTkt5zsJ+3I8wVOj3s0G093QJY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Chris Chiu , Kalle Valo , Ben Hutchings Subject: [PATCH 4.14 31/39] rtl8xxxu: prevent leaking urb Date: Tue, 14 Jan 2020 11:02:05 +0100 Message-Id: <20200114094345.633479616@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200114094336.210038037@linuxfoundation.org> References: <20200114094336.210038037@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Navid Emamdoost commit a2cdd07488e666aa93a49a3fc9c9b1299e27ef3c upstream. In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb should be released. Signed-off-by: Navid Emamdoost Reviewed-by: Chris Chiu Signed-off-by: Kalle Valo Cc: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -5453,6 +5453,7 @@ static int rtl8xxxu_submit_int_urb(struc ret = usb_submit_urb(urb, GFP_KERNEL); if (ret) { usb_unanchor_urb(urb); + usb_free_urb(urb); goto error; }