From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590E1C33CB1 for ; Tue, 14 Jan 2020 10:10:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FAEB24680 for ; Tue, 14 Jan 2020 10:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996649; bh=IAWoV7sLHY7VarPJfk6cJJN8sA4BpJYPO9/iJ9t548g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HipUpfJPTwa/k8Auf8frcHKzgBQ6ZOg49E8Ritg0OW5BTW7Dnu/d29BO5ouzuJeZm 5dtvHoR1RCTXskNWl/nEr8Jo6MJurTV69B/3+yUL0z71exaIUZpXzbxH/B/pdVm7II r3EuzFDFpbGD/7Hhn+xBrY1Ma5YhctFX7+0+AiyQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731892AbgANKKr (ORCPT ); Tue, 14 Jan 2020 05:10:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:45098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731825AbgANKKq (ORCPT ); Tue, 14 Jan 2020 05:10:46 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C6152207FF; Tue, 14 Jan 2020 10:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996646; bh=IAWoV7sLHY7VarPJfk6cJJN8sA4BpJYPO9/iJ9t548g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tnSx6EV3arYRAIO2tDYDoQgFu5jBC1c7H3MgFlgXV71c87PvkhV5K/A2H7Ij3cL6q iVOpdtYeDAyHk7VT2XXgNhMXAod+jsaAg/MDbeS2dhGYyLJb7hm8xZ6RLprvvh1yK5 wfvC+wLtKD9dYEzluWzdfRThVeJHp3kEtSSlxyhM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Kalle Valo , Ben Hutchings Subject: [PATCH 4.14 32/39] ath10k: fix memory leak Date: Tue, 14 Jan 2020 11:02:06 +0100 Message-Id: <20200114094345.804681229@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200114094336.210038037@linuxfoundation.org> References: <20200114094336.210038037@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Navid Emamdoost commit b8d17e7d93d2beb89e4f34c59996376b8b544792 upstream. In ath10k_usb_hif_tx_sg the allocated urb should be released if usb_submit_urb fails. Signed-off-by: Navid Emamdoost Signed-off-by: Kalle Valo Cc: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath10k/usb.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/wireless/ath/ath10k/usb.c +++ b/drivers/net/wireless/ath/ath10k/usb.c @@ -454,6 +454,7 @@ static int ath10k_usb_hif_tx_sg(struct a ath10k_dbg(ar, ATH10K_DBG_USB_BULK, "usb bulk transmit failed: %d\n", ret); usb_unanchor_urb(urb); + usb_free_urb(urb); ret = -EINVAL; goto err_free_urb_to_pipe; }