From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D66C33CB1 for ; Tue, 14 Jan 2020 10:16:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5051C207FF for ; Tue, 14 Jan 2020 10:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578997008; bh=QLRq49Oa3q7afnFXHe3koQkdpAPWSchtx4mPwYc8D+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xpJKtOMwrzNTEYu5pWeVF3sY3gvVKWlS5L+/Ghw9JUvyG7Jxhom0OqvR4MJnYvhFI Rj72cCwXYAR9PG0Defkon5CABu7IFOJR8+kXjya6vSjnCkQiIq9RkR5V9eyYr3Bxma HQ3M60/eipmpY19UwL7iJqUd9A5gshmF+lrWRgMU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730321AbgANKIq (ORCPT ); Tue, 14 Jan 2020 05:08:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:40558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731061AbgANKIq (ORCPT ); Tue, 14 Jan 2020 05:08:46 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 093BB20678; Tue, 14 Jan 2020 10:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996525; bh=QLRq49Oa3q7afnFXHe3koQkdpAPWSchtx4mPwYc8D+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TNC5H0KbB06niGVnD/RvLRL6Pz3oLTwtn7468m3hwOHN/0WZW5/GhfERML7LqY23g mhXewsT2FCsplECEisdfBncBB4WUtjCizqVCTygDlbe1iU+0s/5XyfRmWhmrNfAJst KXv7mDSXbJWNF+YmOjZb9akViIvHAOX6EyOdSuvg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Kenneth R. Crudup" , Sudip Mukherjee Subject: [PATCH 4.19 34/46] tty: always relink the port Date: Tue, 14 Jan 2020 11:01:51 +0100 Message-Id: <20200114094347.142899987@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200114094339.608068818@linuxfoundation.org> References: <20200114094339.608068818@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sudip Mukherjee commit 273f632912f1b24b642ba5b7eb5022e43a72f3b5 upstream. If the serial device is disconnected and reconnected, it re-enumerates properly but does not link it. fwiw, linking means just saving the port index, so allow it always as there is no harm in saving the same value again even if it tries to relink with the same port. Fixes: fb2b90014d78 ("tty: link tty and port before configuring it as console") Reported-by: Kenneth R. Crudup Signed-off-by: Sudip Mukherjee Cc: stable Link: https://lore.kernel.org/r/20191227174434.12057-1-sudipm.mukherjee@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/tty_port.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/tty/tty_port.c +++ b/drivers/tty/tty_port.c @@ -89,8 +89,7 @@ void tty_port_link_device(struct tty_por { if (WARN_ON(index >= driver->num)) return; - if (!driver->ports[index]) - driver->ports[index] = port; + driver->ports[index] = port; } EXPORT_SYMBOL_GPL(tty_port_link_device);