From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9BCC33CB1 for ; Tue, 14 Jan 2020 10:18:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4308424676 for ; Tue, 14 Jan 2020 10:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578997138; bh=bf/93A/tS660991vEZMb8GUK5RE0kZh69l+1eSztkcM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GcevAyausbXSEgdg7TufJ0Y6r5LhsHO8LHUAcDQ7q3v+Y25Ief13a0rT2dNU+Agv9 /Cpp1WyooFmNTD89X0ld1UjKP/oQXr3n8BHKFM7zWSyPxze2jobcya9LMTC7+tp92r jRY8KlVTt8GrmhKfbDUqDqqszWsn16fUN3U9BxtA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729873AbgANKGk (ORCPT ); Tue, 14 Jan 2020 05:06:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:35956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730412AbgANKGk (ORCPT ); Tue, 14 Jan 2020 05:06:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D31524679; Tue, 14 Jan 2020 10:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996399; bh=bf/93A/tS660991vEZMb8GUK5RE0kZh69l+1eSztkcM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yKwAdbEC00/7pcNnR90qh0mI0upe6MuOPR/4TGvyaXEJcIFZWalx5ka6RvNAH81qH ZgVEKAX1oMTGE6Cke1onsS+fEwph/EBQszSzgYaW2AixQkh9P7Zd5oOh25+M2yCoIf hTGNFZ3OZEwIGmk2WV/uUgdfBJ63J/QHSUVkzOMk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Bjorn Andersson , Ben Hutchings Subject: [PATCH 5.4 68/78] rpmsg: char: release allocated memory Date: Tue, 14 Jan 2020 11:01:42 +0100 Message-Id: <20200114094402.501506278@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200114094352.428808181@linuxfoundation.org> References: <20200114094352.428808181@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Navid Emamdoost commit bbe692e349e2a1edf3fe0a29a0e05899c9c94d51 upstream. In rpmsg_eptdev_write_iter, if copy_from_iter_full fails the allocated buffer needs to be released. Signed-off-by: Navid Emamdoost Signed-off-by: Bjorn Andersson Cc: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/rpmsg/rpmsg_char.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rpmsg_char.c @@ -227,8 +227,10 @@ static ssize_t rpmsg_eptdev_write_iter(s if (!kbuf) return -ENOMEM; - if (!copy_from_iter_full(kbuf, len, from)) - return -EFAULT; + if (!copy_from_iter_full(kbuf, len, from)) { + ret = -EFAULT; + goto free_kbuf; + } if (mutex_lock_interruptible(&eptdev->ept_lock)) { ret = -ERESTARTSYS;