From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC176C32771 for ; Fri, 24 Jan 2020 09:34:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96BC8208C4 for ; Fri, 24 Jan 2020 09:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858443; bh=78woVTLbSTJROZLrw0iGAGZ7fAaTmTF1soYlttBTvP4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HeZ2ukzzXPLzj0zH+2IiQei4XSV8ZbSWx4gcpaRlqpHPri65zefaI8F5tOsZNPgMD IU8iP1R3vhwolaO509Q5e04Ut40Yn6PmD96vVICBcmsbda2WhepR2axCYXehfHW17i X6ds+K9hm5OKCM/IkJuYRx/pL4mHav8ztAlsQ7vQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730771AbgAXJeC (ORCPT ); Fri, 24 Jan 2020 04:34:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:60652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730715AbgAXJeB (ORCPT ); Fri, 24 Jan 2020 04:34:01 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E399E2070A; Fri, 24 Jan 2020 09:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858440; bh=78woVTLbSTJROZLrw0iGAGZ7fAaTmTF1soYlttBTvP4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RvH3ljVZcj+xI13iH2Ahrxx558BtAg9ogf4ga8e9kAJEGn+uWE7GV2VEBroMPH/ZU p7Suvsd1fj1jUNyagfJpQEsPqyFUzrRZ3q9rKOm2SICgP08gcY/0lIdcfIuMgzaOux A5WqYbhviyyFTU1e0YBjaXiH0nnwYYM7qdoXexw8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Markus Elfring , Tony Lindgren Subject: [PATCH 5.4 012/102] ARM: OMAP2+: Add missing put_device() call in omapdss_init_of() Date: Fri, 24 Jan 2020 10:30:13 +0100 Message-Id: <20200124092807.991706983@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092806.004582306@linuxfoundation.org> References: <20200124092806.004582306@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Markus Elfring commit 0b491904f053e41685162af5c5411b85b18c97a7 upstream. A coccicheck run provided information like the following. arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device; call of_find_device_by_node on line 258, but without a corresponding object release within this function. Generated by: scripts/coccinelle/free/put_device.cocci Thus add the missed function call to fix the exception handling for this function implementation. Fixes: e0c827aca0730b51f38081aa4e8ecf0912aab55f ("drm/omap: Populate DSS children in omapdss driver") Signed-off-by: Markus Elfring Signed-off-by: Tony Lindgren Signed-off-by: Greg Kroah-Hartman --- arch/arm/mach-omap2/display.c | 1 + 1 file changed, 1 insertion(+) --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -265,6 +265,7 @@ static int __init omapdss_init_of(void) r = of_platform_populate(node, NULL, NULL, &pdev->dev); if (r) { pr_err("Unable to populate DSS submodule devices\n"); + put_device(&pdev->dev); return r; }