From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA9CDC32771 for ; Fri, 24 Jan 2020 09:39:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8579920709 for ; Fri, 24 Jan 2020 09:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858778; bh=uDfNVJ2e3B9w85wc4tQZGUV7MtasnpvtfhWO9cknEl4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vLJHzmnXGP4eC4mRHz9p/MufIBlCvUDszwAlgUlEG//r3+h11XB28pF/FCy5kWItw V3RmJVo0d/uC5P43qPgoNF+O1x1ZbQPCsUSSsjTawnS5M+yaGdellZ2NhL2j2NbX1z rZghdEbPDKcnlQn9jIqxuybZEKt/0HLbKRQPR//M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731723AbgAXJje (ORCPT ); Fri, 24 Jan 2020 04:39:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:36694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731650AbgAXJjd (ORCPT ); Fri, 24 Jan 2020 04:39:33 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6D6C2070A; Fri, 24 Jan 2020 09:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858773; bh=uDfNVJ2e3B9w85wc4tQZGUV7MtasnpvtfhWO9cknEl4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LE9HhlC+dWhqHkD+htxhDVOurmaOjeDWOaYShnWZLYXinY1O+tXlPtYKQmzNbYz9l g4yCUakv9uycYl0H3M8NW652h7IxU4PkgQqkjVD6MVh+ptOEEBDC/2Ob+apasuoL3/ yuL3HriJnNQIbkg7OPHXXhMMVIQo/3osDga2M4XI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Patrick Steinhardt , "J. Bruce Fields" Subject: [PATCH 5.4 036/102] nfsd: depend on CRYPTO_MD5 for legacy client tracking Date: Fri, 24 Jan 2020 10:30:37 +0100 Message-Id: <20200124092811.711425818@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092806.004582306@linuxfoundation.org> References: <20200124092806.004582306@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Patrick Steinhardt commit 38a2204f5298620e8a1c3b1dc7b831425106dbc0 upstream. The legacy client tracking infrastructure of nfsd makes use of MD5 to derive a client's recovery directory name. As the nfsd module doesn't declare any dependency on CRYPTO_MD5, though, it may fail to allocate the hash if the kernel was compiled without it. As a result, generation of client recovery directories will fail with the following error: NFSD: unable to generate recoverydir name The explicit dependency on CRYPTO_MD5 was removed as redundant back in 6aaa67b5f3b9 (NFSD: Remove redundant "select" clauses in fs/Kconfig 2008-02-11) as it was already implicitly selected via RPCSEC_GSS_KRB5. This broke when RPCSEC_GSS_KRB5 was made optional for NFSv4 in commit df486a25900f (NFS: Fix the selection of security flavours in Kconfig) at a later point. Fix the issue by adding back an explicit dependency on CRYPTO_MD5. Fixes: df486a25900f (NFS: Fix the selection of security flavours in Kconfig) Signed-off-by: Patrick Steinhardt Signed-off-by: J. Bruce Fields Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/Kconfig | 1 + 1 file changed, 1 insertion(+) --- a/fs/nfsd/Kconfig +++ b/fs/nfsd/Kconfig @@ -73,6 +73,7 @@ config NFSD_V4 select NFSD_V3 select FS_POSIX_ACL select SUNRPC_GSS + select CRYPTO_MD5 select CRYPTO_SHA256 select GRACE_PERIOD help