From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7EBAC35242 for ; Fri, 24 Jan 2020 09:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A53AE21556 for ; Fri, 24 Jan 2020 09:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858970; bh=9ikAnuKXYVTrUYZSVlqYyhEwoHYAgpuy6/5q5PQ9Ins=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rOEaS5GOWM6ef7KQKegpVg/mifHr9EETCGQM+ZkPBHjBgo9mlgdDiuQbqCSO2WqwV n4L/XPyl7xSpqjRxMY+WSr7/bWFvFN+2UUxcWFovnZbtoHTyxFbQplodhnZYK2NrtZ qgnvnvBaMRlPRBle+K62Z3F6gSD6CtSjeSpRpZbc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732685AbgAXJmi (ORCPT ); Fri, 24 Jan 2020 04:42:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:40332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731166AbgAXJmi (ORCPT ); Fri, 24 Jan 2020 04:42:38 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79F06208C4; Fri, 24 Jan 2020 09:42:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858958; bh=9ikAnuKXYVTrUYZSVlqYyhEwoHYAgpuy6/5q5PQ9Ins=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OGgaB6atmizK5u+S7ctRvHxpKQ+pfwMEfICwmKRIplFIUT0cl9oJF0/kHLWpitmIn ulX0gOyipy8FMUqpn0k8ZsQOflMZdb4U/sxvVieC5T14Y8YGXV44MdnGZ6j9JIqq0n 7JbSXnJ9KAoN1b4ebSM0Cj0q4P3FGuTVfwiU0iiI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Andrew Jeffery , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.4 100/102] gpio: aspeed: avoid return type warning Date: Fri, 24 Jan 2020 10:31:41 +0100 Message-Id: <20200124092821.829200623@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092806.004582306@linuxfoundation.org> References: <20200124092806.004582306@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 11e299de3aced4ea23a9fb1fef6c983c8d516302 ] gcc has a hard time tracking whether BUG_ON(1) ends execution or not: drivers/gpio/gpio-aspeed-sgpio.c: In function 'bank_reg': drivers/gpio/gpio-aspeed-sgpio.c:112:1: error: control reaches end of non-void function [-Werror=return-type] Use the simpler BUG() that gcc knows cannot continue. Fixes: f8b410e3695a ("gpio: aspeed-sgpio: Rename and add Kconfig/Makefile") Signed-off-by: Arnd Bergmann Acked-by: Andrew Jeffery Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/sgpio-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/gpio/sgpio-aspeed.c index 7e99860ca447e..8319812593e31 100644 --- a/drivers/gpio/sgpio-aspeed.c +++ b/drivers/gpio/sgpio-aspeed.c @@ -107,7 +107,7 @@ static void __iomem *bank_reg(struct aspeed_sgpio *gpio, return gpio->base + bank->irq_regs + GPIO_IRQ_STATUS; default: /* acturally if code runs to here, it's an error case */ - BUG_ON(1); + BUG(); } } -- 2.20.1