From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B89D5C352A4 for ; Mon, 10 Feb 2020 13:35:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8251820714 for ; Mon, 10 Feb 2020 13:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581341733; bh=Cp/VK6nfiVSaC+soGMfVisN6+gMQX5SyxkcYr2+iGkc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jBXaAXAVW/zQDAP0e5iV//PmsLoQMc0fnlELK5ZcBRpXVER/Zi00xZpRH3Vp5WXba HQ3OXR0SYYO91EI9kKEPazzxDdQlz1oly/Q7VYH97TESRUQjdTe5wx4ZAGtsyH8ZtT Klb2CdFKRvtpxpf2aoSY9TExHcs2Jt/24Ew3Fp+8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728044AbgBJNf3 (ORCPT ); Mon, 10 Feb 2020 08:35:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:52128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727868AbgBJMfU (ORCPT ); Mon, 10 Feb 2020 07:35:20 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 721742467A; Mon, 10 Feb 2020 12:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338120; bh=Cp/VK6nfiVSaC+soGMfVisN6+gMQX5SyxkcYr2+iGkc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l4RUiq6EfBml9blAkWbO/1YSPnlXbqfmVP/FHm+9fO8TDyktrRpyBGytsr1blgS9z hzoFQJf6dIZll7DyjjFCH+uIom12pG6R+UY62b5mV7A7Ly5FHDsO/Did/ZKpxqBdM8 aHol/OcorzEELyA7A7oeXFWJLDnpO5dt7yqUMNmA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavel Shilovsky , Steve French , Ronnie Sahlberg , Sasha Levin Subject: [PATCH 4.19 056/195] smb3: fix signing verification of large reads Date: Mon, 10 Feb 2020 04:31:54 -0800 Message-Id: <20200210122311.487156021@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122305.731206734@linuxfoundation.org> References: <20200210122305.731206734@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Steve French [ Upstream commit 46f17d17687e8140f2e4e517d7dfa65e62fcc5f4 ] Code cleanup in the 5.1 kernel changed the array passed into signing verification on large reads leading to warning messages being logged when copying files to local systems from remote. SMB signature verification returned error = -5 This changeset fixes verification of SMB3 signatures of large reads. Suggested-by: Pavel Shilovsky Signed-off-by: Steve French Reviewed-by: Ronnie Sahlberg Signed-off-by: Sasha Levin --- fs/cifs/smb2pdu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -3130,8 +3130,8 @@ smb2_readv_callback(struct mid_q_entry * struct smb2_sync_hdr *shdr = (struct smb2_sync_hdr *)rdata->iov[0].iov_base; unsigned int credits_received = 0; - struct smb_rqst rqst = { .rq_iov = rdata->iov, - .rq_nvec = 2, + struct smb_rqst rqst = { .rq_iov = &rdata->iov[1], + .rq_nvec = 1, .rq_pages = rdata->pages, .rq_offset = rdata->page_offset, .rq_npages = rdata->nr_pages,