From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAD86C352A5 for ; Mon, 10 Feb 2020 13:35:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7987E2080C for ; Mon, 10 Feb 2020 13:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581341719; bh=wvKp2q99nRBiRC5mtyIHVKjE2rlgtcti68SxKBOh2HA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xyTTkbQqtw+TicFo6W/6wLGhyEk+CIBaiVZtzxuAspF/G9zCbSH8gWohEtlBc1wyO KoCQ/hl4dLHJsPzbLjN/1hdRky7bZQ8xbjmG9CJyC+oymDgUTfpB5NYX2in6VFXHF6 KVrojsl698NsoiVKqnsPCl4HAofIJsNZVyZNcPIs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727878AbgBJMfV (ORCPT ); Mon, 10 Feb 2020 07:35:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:51476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727872AbgBJMfV (ORCPT ); Mon, 10 Feb 2020 07:35:21 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC01320661; Mon, 10 Feb 2020 12:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338121; bh=wvKp2q99nRBiRC5mtyIHVKjE2rlgtcti68SxKBOh2HA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZoK6iFcG7hw4KLMIM+dZutzpYrq6KGsiYGofY/LP8fk2h85MCQS2WIT2ap5TXkfb6 iiEoaZ5mS7hqrWG/RXl4gen5xy/0bny+iXLM9gmCacOtrAS1WHmtgv61l6GjeUHsKH 5iybwSlrM0sBeXpTJ3cWgej0R7keR4g+uAoPp0dE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Engraf , Bjorn Helgaas , Lorenzo Pieralisi , Andrew Murray Subject: [PATCH 4.19 057/195] PCI: tegra: Fix return value check of pm_runtime_get_sync() Date: Mon, 10 Feb 2020 04:31:55 -0800 Message-Id: <20200210122311.572246879@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122305.731206734@linuxfoundation.org> References: <20200210122305.731206734@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: David Engraf commit 885199148442f56b880995d703d2ed03b6481a3c upstream. pm_runtime_get_sync() returns the device's usage counter. This might be >0 if the device is already powered up or CONFIG_PM is disabled. Abort probe function on real error only. Fixes: da76ba50963b ("PCI: tegra: Add power management support") Link: https://lore.kernel.org/r/20191216111825.28136-1-david.engraf@sysgo.com Signed-off-by: David Engraf Signed-off-by: Bjorn Helgaas Signed-off-by: Lorenzo Pieralisi Acked-by: Andrew Murray Cc: stable@vger.kernel.org # v4.17+ Signed-off-by: Greg Kroah-Hartman --- drivers/pci/controller/pci-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/pci/controller/pci-tegra.c +++ b/drivers/pci/controller/pci-tegra.c @@ -2398,7 +2398,7 @@ static int tegra_pcie_probe(struct platf pm_runtime_enable(pcie->dev); err = pm_runtime_get_sync(pcie->dev); - if (err) { + if (err < 0) { dev_err(dev, "fail to enable pcie controller: %d\n", err); goto teardown_msi; }