From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7744C352A4 for ; Mon, 10 Feb 2020 13:23:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6CBE20715 for ; Mon, 10 Feb 2020 13:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581340981; bh=BSn5R7azljg7e9o9BU85gK//ULJ7l3w8oNS873dz39k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mJvj0bl1eG7X8Boz6r4SOp90iRivrGX/UbmYAzb/g46EWtiL+OrnxrO0J+gmJrrfW dEoB+BBJdiTzaP3jHXY/E+D7LQG2+sQTLMPU7oGESwWDgBR976AbnHpnaG1hE7f3mY Qu+NRj7IAhb7WWSahc8/3Fv/+VzSy0BQTDlwbgAU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729544AbgBJNXB (ORCPT ); Mon, 10 Feb 2020 08:23:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:58588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728693AbgBJMhQ (ORCPT ); Mon, 10 Feb 2020 07:37:16 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A4B02080C; Mon, 10 Feb 2020 12:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338236; bh=BSn5R7azljg7e9o9BU85gK//ULJ7l3w8oNS873dz39k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u7FtrD83TyQiU2A8KmkEIvicQKBM6AXV5izQ+mhZGHovJ703x9xWklcc3OF0DPwp5 wX3PLwzCe4poKC3U2juRiIdkprre07Ld5CaJs/RhdUqeAZScK0XUMuPfwRJlCVJgFG EleJ/gFwDvYggveClEndVVGcBFtLtNZHRW//Q9Wc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yurii Monakov , Lorenzo Pieralisi , Andrew Murray Subject: [PATCH 5.4 083/309] PCI: keystone: Fix link training retries initiation Date: Mon, 10 Feb 2020 04:30:39 -0800 Message-Id: <20200210122413.814917714@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122406.106356946@linuxfoundation.org> References: <20200210122406.106356946@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yurii Monakov commit 6df19872d881641e6394f93ef2938cffcbdae5bb upstream. ks_pcie_stop_link() function does not clear LTSSM_EN_VAL bit so link training was not triggered more than once after startup. In configurations where link can be unstable during early boot, for example, under low temperature, it will never be established. Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver") Signed-off-by: Yurii Monakov Signed-off-by: Lorenzo Pieralisi Acked-by: Andrew Murray Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/pci/controller/dwc/pci-keystone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -510,7 +510,7 @@ static void ks_pcie_stop_link(struct dw_ /* Disable Link training */ val = ks_pcie_app_readl(ks_pcie, CMD_STATUS); val &= ~LTSSM_EN_VAL; - ks_pcie_app_writel(ks_pcie, CMD_STATUS, LTSSM_EN_VAL | val); + ks_pcie_app_writel(ks_pcie, CMD_STATUS, val); } static int ks_pcie_start_link(struct dw_pcie *pci)