From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B948EC352A3 for ; Mon, 10 Feb 2020 13:21:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8653F20656 for ; Mon, 10 Feb 2020 13:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581340876; bh=P2P9PPE0X1cAHxUj8UmWpDqIIESyqK2eK64QMFd/H7c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Xcpomh55jHjZPiiKBFniPE0T1+rCwgl9H742YAenvCE5vW7jBvBQgqYt5eGzrXvqg /5FcaIdDJ28ujaB4yeqM3mNyk1ieAn1XZV1RzVGpJY5q/o+XwtsdAmyqhcBy8RWVVJ SZ1Wh/b1+yeXj776tOitx1T+3TEdWDD36j0f4Tnc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728856AbgBJNVP (ORCPT ); Mon, 10 Feb 2020 08:21:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:59498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728798AbgBJMhd (ORCPT ); Mon, 10 Feb 2020 07:37:33 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1088020838; Mon, 10 Feb 2020 12:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338253; bh=P2P9PPE0X1cAHxUj8UmWpDqIIESyqK2eK64QMFd/H7c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ahRVUxZCnx0Ii01dSVMsfHNe2gGBKrdhpnZByjwyeHdl/p2vDifVayg/h2pBkAB1U 3oMznm0SjAY5TjFjMp9ligrB9PYLRUMUdFdxtRJbjXek+tF2ggVTzNqwGLNElyPWbi hr9/nd7d3UJ9OrImN29Xcw9KuyaRP7iqUZbLJOiI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Boris Gjenero , Miklos Szeredi Subject: [PATCH 5.4 117/309] ovl: fix lseek overflow on 32bit Date: Mon, 10 Feb 2020 04:31:13 -0800 Message-Id: <20200210122417.776025947@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122406.106356946@linuxfoundation.org> References: <20200210122406.106356946@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Miklos Szeredi commit a4ac9d45c0cd14a2adc872186431c79804b77dbf upstream. ovl_lseek() is using ssize_t to return the value from vfs_llseek(). On a 32-bit kernel ssize_t is a 32-bit signed int, which overflows above 2 GB. Assign the return value of vfs_llseek() to loff_t to fix this. Reported-by: Boris Gjenero Fixes: 9e46b840c705 ("ovl: support stacked SEEK_HOLE/SEEK_DATA") Cc: # v4.19 Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/overlayfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/overlayfs/file.c +++ b/fs/overlayfs/file.c @@ -146,7 +146,7 @@ static loff_t ovl_llseek(struct file *fi struct inode *inode = file_inode(file); struct fd real; const struct cred *old_cred; - ssize_t ret; + loff_t ret; /* * The two special cases below do not need to involve real fs,