From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FD0AC2BA83 for ; Thu, 13 Feb 2020 15:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD25920661 for ; Thu, 13 Feb 2020 15:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581608968; bh=5IHAgVIK4KTq1hgs6co910tH1rCw+oBCf0E6d10O9A0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FrYCxIB5pLEfdUqbvxXG6yQMyqlBU/ELrCNoH0U+8p47NFdxiJHU/1aHKcboBZcJy rizWL9EUXAjB8izOeOmUaqxGwiCcPkB2y9Zfo65RH49Qoho0bukHiQJ9Fnl3eIEv3N OPVTI3ZvnabkWkRbMFqW8bm+aqOfVyO16w4UJ2Uk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729928AbgBMPtT (ORCPT ); Thu, 13 Feb 2020 10:49:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:46958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387626AbgBMP0p (ORCPT ); Thu, 13 Feb 2020 10:26:45 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 096E1206DB; Thu, 13 Feb 2020 15:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607604; bh=5IHAgVIK4KTq1hgs6co910tH1rCw+oBCf0E6d10O9A0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D/0cSHTUWlSmwH00qsIr6L3ZGC41/fNOQjcECZYSkG2SY53FxObRzz8Et/pvxctCQ U1FeBCichWCPzH5U/1MLDFPCkasaWd0gwEomMSVDkQ8OAVhy7LbeG7xv071Uhsy9cq cqFG9MPs4rxMKRFFN+sBVsFKPgrZLvrDQBw3sRwo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jesper Nilsson , Lars Persson , Eric Biggers , Herbert Xu Subject: [PATCH 4.19 42/52] crypto: artpec6 - return correct error code for failed setkey() Date: Thu, 13 Feb 2020 07:21:23 -0800 Message-Id: <20200213151827.432558505@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151810.331796857@linuxfoundation.org> References: <20200213151810.331796857@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Eric Biggers commit b828f905904cd76424230c69741a4cabb0174168 upstream. ->setkey() is supposed to retun -EINVAL for invalid key lengths, not -1. Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver") Cc: Jesper Nilsson Cc: Lars Persson Signed-off-by: Eric Biggers Acked-by: Lars Persson Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/axis/artpec6_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/crypto/axis/artpec6_crypto.c +++ b/drivers/crypto/axis/artpec6_crypto.c @@ -1256,7 +1256,7 @@ static int artpec6_crypto_aead_set_key(s if (len != 16 && len != 24 && len != 32) { crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); - return -1; + return -EINVAL; } ctx->key_length = len;