From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B8F7C3B189 for ; Thu, 13 Feb 2020 16:00:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 732D220675 for ; Thu, 13 Feb 2020 16:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581609607; bh=5mxg45Xl7Uz5gGdjO/pHTmMOEMHmzQQPmWIWxAtzhUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IaGrkJgVPj1BJNWzcUdlBfy2RoG5ynCShmr94vacoHly7t/XmDF+pWQ05AV8heVbq EyC55S5i5meNgJush4J0hhZ/IkUOohzD+h76PN0s8s3DHAaUgWgeqeoSG9Uek2ua86 bzpZlVeHa7u4/4PNYVtgT2vtUHXpe52qfMv6f8WQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728921AbgBMP77 (ORCPT ); Thu, 13 Feb 2020 10:59:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:39204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728799AbgBMPYt (ORCPT ); Thu, 13 Feb 2020 10:24:49 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B5722469A; Thu, 13 Feb 2020 15:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607489; bh=5mxg45Xl7Uz5gGdjO/pHTmMOEMHmzQQPmWIWxAtzhUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lUBuRD/p6+iq4YjWFR2wETS+ukhgbnLTb7HoR8MxdEkx83bzbrYW9xTV9bnylv44t X32RtnuYe9rd4Bbglp47vg9QuGjoMTwbp1fgb8SSrrVtadDG7nd2As8ZOdtqL59djg H+4I69doMuZma8D/CIFRIjOsjY6zZx2fMMF20vSI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Chan , Jakub Kicinski Subject: [PATCH 4.14 011/173] bnxt_en: Fix TC queue mapping. Date: Thu, 13 Feb 2020 07:18:34 -0800 Message-Id: <20200213151935.417475519@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151931.677980430@linuxfoundation.org> References: <20200213151931.677980430@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Michael Chan [ Upstream commit 18e4960c18f484ac288f41b43d0e6c4c88e6ea78 ] The driver currently only calls netdev_set_tc_queue when the number of TCs is greater than 1. Instead, the comparison should be greater than or equal to 1. Even with 1 TC, we need to set the queue mapping. This bug can cause warnings when the number of TCs is changed back to 1. Fixes: 7809592d3e2e ("bnxt_en: Enable MSIX early in bnxt_init_one().") Signed-off-by: Michael Chan Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -5375,7 +5375,7 @@ static void bnxt_setup_msix(struct bnxt int tcs, i; tcs = netdev_get_num_tc(dev); - if (tcs > 1) { + if (tcs) { int i, off, count; for (i = 0; i < tcs; i++) {