From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C7CC35242 for ; Fri, 14 Feb 2020 23:59:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CE732072D for ; Fri, 14 Feb 2020 23:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581724792; bh=kdcvtJLmnTtzWUQS0+tFQbmbizzUANyG9omQMu4DSRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PYJSzByY6I9lk5WchFHEYOWx1iON9QBt2h3Q7NeqRiG6gDXx1Jc14cT1PqPnI2Zlc LmCI5AxBVmdjt3ZOspi2jefkV8Wk6POgfdVbCGSQnphpj1xZPVA0NJWg6XROYA86ZI FCfMbCuwaEKUyShARN2+ykd4Lbp5POM3WLcFDoW4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728009AbgBNX7w (ORCPT ); Fri, 14 Feb 2020 18:59:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:38312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727935AbgBNX7v (ORCPT ); Fri, 14 Feb 2020 18:59:51 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 039B2206B6; Fri, 14 Feb 2020 23:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581724791; bh=kdcvtJLmnTtzWUQS0+tFQbmbizzUANyG9omQMu4DSRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=raLSWtEZHlFlaXAJTM8RqjpN+mb5UJy42NT1cOjfH8kY9ByeF2ZLivS+3qfWn8S9q QZJEkNTe/0RXnJJI8sUxzmXpTLb0DbZPpn5i+ONXTK7FNmWA5EMb4rJh5GzSaG2AZf Qf0F5A52NVjAD/3qlr5/TB+G9r9XeaIed7r6V9SM= Date: Fri, 14 Feb 2020 18:59:49 -0500 From: Sasha Levin To: Greg KH Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, zhengbin , Hulk Robot , Felix Kuehling , Alex Deucher , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH AUTOSEL 5.5 155/542] drm/amdkfd: remove set but not used variable 'top_dev' Message-ID: <20200214235949.GG1734@sasha-vm> References: <20200214154854.6746-1-sashal@kernel.org> <20200214154854.6746-155-sashal@kernel.org> <20200214214429.GA4193448@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200214214429.GA4193448@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Feb 14, 2020 at 04:44:29PM -0500, Greg KH wrote: >On Fri, Feb 14, 2020 at 10:42:27AM -0500, Sasha Levin wrote: >> From: zhengbin >> >> [ Upstream commit d191bd678153307573d615bb42da4fcca19fe477 ] >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c: In function kfd_iommu_device_init: >> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c:65:30: warning: variable top_dev set but not used [-Wunused-but-set-variable] >> >> Reported-by: Hulk Robot >> Fixes: 1ae99eab34f9 ("drm/amdkfd: Initialize HSA_CAP_ATS_PRESENT capability in topology codes") >> Signed-off-by: zhengbin >> Reviewed-by: Felix Kuehling >> Signed-off-by: Felix Kuehling >> Signed-off-by: Alex Deucher >> Signed-off-by: Sasha Levin >> --- >> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 3 --- >> 1 file changed, 3 deletions(-) > >Unless all of these "unused bt set variable" patches are needed for >"real" fixes, there's no need to add them here as we are NOT building >the kernel with that option enabled any time soon from what I can tell. > >So you can drop a ton of these patches from all of these AUTOSEL >branches please. Sigh, I confused the -Wno-unused-but-set-variable flag we pass in the makefile with -Wunused-but-set-variable. Sorry about all this noise, I'll drop it. -- Thanks, Sasha