From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C80FC3F2D2 for ; Thu, 5 Mar 2020 17:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5ECE207FD for ; Thu, 5 Mar 2020 17:16:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428612; bh=CEZE2M2M19p/tI/qitCnZMFSK+sh5USz35jRAEJmX4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=brbbur92g5IhsscswGeBJNLomNDJJ6P9L3Lar3pe4TFD/c+DVqqCbXY7DWVuVj14h VaJv8gGeG3qUIzN6YLKnhaG6XQXgiDEm4fKuYeFjsUXmGxpaUUOB+O20FG+weKWAsp 4uv0jo3/syjM3xTjl6Xy/Kp7CxjeJHdViP2FUKRc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728414AbgCERQL (ORCPT ); Thu, 5 Mar 2020 12:16:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:43228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728409AbgCERQL (ORCPT ); Thu, 5 Mar 2020 12:16:11 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0593B21556; Thu, 5 Mar 2020 17:16:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428570; bh=CEZE2M2M19p/tI/qitCnZMFSK+sh5USz35jRAEJmX4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PnfKHpd2xcOs2rkVtjpn0P1UlX0mSjn35GG7GVx7yqdluY3gDdLU8CZkUG8vIGPXJ ZBJNDsk3USQHKUrzfpks+7Azs2KQOqM1FNC9zIcKcqmD0d6vS++mfmdTUoBR+joh2B A8AY85z+CyOO969F9Ruj86QOq7/T0ksT7zcuwM4Q= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Madhuparna Bhowmik , Johannes Berg , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 09/12] mac80211: rx: avoid RCU list traversal under mutex Date: Thu, 5 Mar 2020 12:15:56 -0500 Message-Id: <20200305171559.30422-9-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200305171559.30422-1-sashal@kernel.org> References: <20200305171559.30422-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Madhuparna Bhowmik [ Upstream commit 253216ffb2a002a682c6f68bd3adff5b98b71de8 ] local->sta_mtx is held in __ieee80211_check_fast_rx_iface(). No need to use list_for_each_entry_rcu() as it also requires a cond argument to avoid false lockdep warnings when not used in RCU read-side section (with CONFIG_PROVE_RCU_LIST). Therefore use list_for_each_entry(); Signed-off-by: Madhuparna Bhowmik Link: https://lore.kernel.org/r/20200223143302.15390-1-madhuparnabhowmik10@gmail.com Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 74652eb2f90fd..a6f265262f151 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -3841,7 +3841,7 @@ void __ieee80211_check_fast_rx_iface(struct ieee80211_sub_if_data *sdata) lockdep_assert_held(&local->sta_mtx); - list_for_each_entry_rcu(sta, &local->sta_list, list) { + list_for_each_entry(sta, &local->sta_list, list) { if (sdata != sta->sdata && (!sta->sdata->bss || sta->sdata->bss != sdata->bss)) continue; -- 2.20.1