From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39768C10DCE for ; Tue, 24 Mar 2020 08:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 044EF2080C for ; Tue, 24 Mar 2020 08:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585037237; bh=f8cT9sVNNjuDD13bqAKIx8zkKrrCSqGk4wXhPLqd06A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Pzphiux2We5CD+0IfONeGgioqDm1G+pfQ8N2AO7oLoZ6rBAoADONou0JKP8/gzTjK mf4k5//Mfs07BOeDJ7AjG/hC6Ew2VzjUatDMOtXKhusgLdNa82LEsoZZ9d/uidH6DR cSLE7aS0YrqSBFzjn7X6bkZHikk0rlHp7LBysGGA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726240AbgCXIHN (ORCPT ); Tue, 24 Mar 2020 04:07:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:34132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726079AbgCXIHN (ORCPT ); Tue, 24 Mar 2020 04:07:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13DD02080C; Tue, 24 Mar 2020 08:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585037231; bh=f8cT9sVNNjuDD13bqAKIx8zkKrrCSqGk4wXhPLqd06A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TpSU/mZC0wXo/ef1oShGUKm46qphvClM+NpopQTyyrz+3CeZHh7zgv7NXEWW17BZO ngqF+9OVsfJp/XyEXm5x2O+/KvfMFwQvBMcHzmS5ABf2FL8BYPjJFqp1ZNOiFDNcFR 9iEfXcSWy83PCJ+FmPMhORLwNjsMSxj7Y7sLFZOc= Date: Tue, 24 Mar 2020 09:06:33 +0100 From: Greg Kroah-Hartman To: Jann Horn Cc: Sasha Levin , stable , kernel list , Peter Zijlstra , Linus Torvalds , linux-fsdevel Subject: Re: [PATCH AUTOSEL 5.4 30/73] futex: Fix inode life-time issue Message-ID: <20200324080633.GA2016351@kroah.com> References: <20200318205337.16279-1-sashal@kernel.org> <20200318205337.16279-30-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Mar 23, 2020 at 08:18:04PM +0100, Jann Horn wrote: > On Wed, Mar 18, 2020 at 9:54 PM Sasha Levin wrote: > > > > From: Peter Zijlstra > > > > [ Upstream commit 8019ad13ef7f64be44d4f892af9c840179009254 ] > > > > As reported by Jann, ihold() does not in fact guarantee inode > > persistence. And instead of making it so, replace the usage of inode > > pointers with a per boot, machine wide, unique inode identifier. > > > > This sequence number is global, but shared (file backed) futexes are > > rare enough that this should not become a performance issue. > > Please also take this patch, together with > 8d67743653dce5a0e7aa500fcccb237cde7ad88e "futex: Unbreak futex > hashing", into the older stable branches. This has to go all the way > back; as far as I can tell, the bug already existed at the beginning > of git history. I have queued these up now, thanks for the hint. greg k-h