From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAE5C2BAEE for ; Tue, 24 Mar 2020 13:26:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86A5A20936 for ; Tue, 24 Mar 2020 13:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585056406; bh=d/nncTjMbeeP58TbJXgNgimGrQxhP15wf/xapbEf5xI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=x6z7JG77b7ro4UmNzL6/K3gP1KeeHqpYmQ+wmb4p4NLmz2tpgt8q3Q7dlBUQVcpcS ovrINDB7moQDjhdKX7fEbbvSRyTcbDLu7Dfi5W16nUfAiNEOPkV8FAOaKQMwqlq1U7 a7eiPebn5Y3Vj9cnAujrOWI3cUPLY95uIN8ti1AE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728816AbgCXN0m (ORCPT ); Tue, 24 Mar 2020 09:26:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:51714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729372AbgCXN0l (ORCPT ); Tue, 24 Mar 2020 09:26:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD245208CA; Tue, 24 Mar 2020 13:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585056401; bh=d/nncTjMbeeP58TbJXgNgimGrQxhP15wf/xapbEf5xI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QiO6u3inqO8ztBt6KL8Mych0TmPqrJ//AcAG6XW9jM417SKlCe0MFXJ/J/IHMrVur PNUNIbbTr2ymvzY16NexmxPCBLQZE6YZiCQu1zzD0xu2KOL5WeQKBA8qXQ7YGtFM3k L8G49GmXXHtGdx4yBWYnYNukOvs95uOTpD3dNmk0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Mika Westerberg Subject: [PATCH 5.5 106/119] thunderbolt: Fix error code in tb_port_is_width_supported() Date: Tue, 24 Mar 2020 14:11:31 +0100 Message-Id: <20200324130818.500007743@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200324130808.041360967@linuxfoundation.org> References: <20200324130808.041360967@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter commit e9d0e7511fda92a6511904996dd0aa57b6d7687a upstream. This function is type bool, and it's supposed to return true on success. Unfortunately, this path takes negative error codes and casts them to bool (true) so it's treated as success instead of failure. Fixes: 91c0c12080d0 ("thunderbolt: Add support for lane bonding") Signed-off-by: Dan Carpenter Signed-off-by: Mika Westerberg Signed-off-by: Greg Kroah-Hartman --- drivers/thunderbolt/switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -848,7 +848,7 @@ static bool tb_port_is_width_supported(s ret = tb_port_read(port, &phy, TB_CFG_PORT, port->cap_phy + LANE_ADP_CS_0, 1); if (ret) - return ret; + return false; widths = (phy & LANE_ADP_CS_0_SUPPORTED_WIDTH_MASK) >> LANE_ADP_CS_0_SUPPORTED_WIDTH_SHIFT;