From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02227C2D0E8 for ; Thu, 26 Mar 2020 23:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C075420663 for ; Thu, 26 Mar 2020 23:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585265377; bh=PeTDMw3nRCBw4/oxwowD4LBFId4p+3zqIbM4DptIbmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Tv4P5t1jGxr4TLn9q6azzaG5Dl0zBpNdAI2/JSQluOW6K9UUo/vDFW2ynxDoUZrFS XuNbLWp3nmyVTfExO8pqV73VibKG0/lwFONdt1OIuNvvsEPgFQI9RKkm/pX+0iUu2Y HcDr0mQvFLBAnc0/+/IUaBHc+BxWuA/ce68DWckc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727683AbgCZX3d (ORCPT ); Thu, 26 Mar 2020 19:29:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:43168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727653AbgCZXYD (ORCPT ); Thu, 26 Mar 2020 19:24:03 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1594420719; Thu, 26 Mar 2020 23:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585265042; bh=PeTDMw3nRCBw4/oxwowD4LBFId4p+3zqIbM4DptIbmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PaUeg7zl6P1Fms1ZKKiVU7dFCxxMQBX/CQ/+1nr89K2/pKUxZNEYVd8ib3zXhRsVa Pn7t66OBLZJ+yxziMlQ8vHS04qHEN3I6eJaqEg+CBfxAjBp/z9fBo9tCZX021W8Mnr RKnVIr3+i929LtWxTZaCpb1xgbkE+KgZlnfcDnTk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kai-Heng Feng , Takashi Iwai , Sasha Levin , alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.5 04/28] ALSA: hda/realtek: Fix pop noise on ALC225 Date: Thu, 26 Mar 2020 19:23:33 -0400 Message-Id: <20200326232357.7516-4-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200326232357.7516-1-sashal@kernel.org> References: <20200326232357.7516-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kai-Heng Feng [ Upstream commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757 ] Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") makes the ALC225 have pop noise on S3 resume and cold boot. So partially revert this commit for ALC225 to fix the regression. Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") BugLink: https://bugs.launchpad.net/bugs/1866357 Signed-off-by: Kai-Heng Feng Link: https://lore.kernel.org/r/20200311061328.17614-1-kai.heng.feng@canonical.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 835af7d2bbd4d..6afa8e195044a 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8051,6 +8051,8 @@ static int patch_alc269(struct hda_codec *codec) spec->gen.mixer_nid = 0; break; case 0x10ec0225: + codec->power_save_node = 1; + /* fall through */ case 0x10ec0295: case 0x10ec0299: spec->codec_variant = ALC269_TYPE_ALC225; -- 2.20.1