stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 13/15] ARM: dts: mmp3: Drop usb-nop-xceiv from HSIC phy
       [not found] <20200419171157.672999-1-lkundrak@v3.sk>
@ 2020-04-19 17:11 ` Lubomir Rintel
  2020-04-19 17:11 ` [PATCH 14/15] ARM: dts: mmp3: Use the MMP3 compatible string for /clocks Lubomir Rintel
  2020-04-19 17:11 ` [PATCH 15/15] ARM: dts: mmp3-dell-ariel: Fix the SPI devices Lubomir Rintel
  2 siblings, 0 replies; 3+ messages in thread
From: Lubomir Rintel @ 2020-04-19 17:11 UTC (permalink / raw)
  To: soc
  Cc: Olof Johansson, Arnd Bergmann, Linux ARM, Daniel Mack,
	Haojian Zhuang, Robert Jarzmik, linux-kernel, Lubomir Rintel,
	stable

"usb-nop-xceiv" is good enough if we don't lose the configuration done
by the firmware, but we'd really prefer a real driver.

Unfortunately, the PHY core is odd in that when the node is compatible
with "usb-nop-xceiv", it ignores the other compatible strings. Let's
just remove it.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Cc: <stable@vger.kernel.org>
---
 arch/arm/boot/dts/mmp3.dtsi | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi
index ae264af12c287..f97fb64404659 100644
--- a/arch/arm/boot/dts/mmp3.dtsi
+++ b/arch/arm/boot/dts/mmp3.dtsi
@@ -202,8 +202,7 @@ usb_otg0: usb@d4208000 {
 			};
 
 			hsic_phy0: usb-phy@f0001800 {
-				compatible = "marvell,mmp3-hsic-phy",
-					     "usb-nop-xceiv";
+				compatible = "marvell,mmp3-hsic-phy";
 				reg = <0xf0001800 0x40>;
 				#phy-cells = <0>;
 				status = "disabled";
@@ -224,8 +223,7 @@ hsic0: usb@f0001000 {
 			};
 
 			hsic_phy1: usb-phy@f0002800 {
-				compatible = "marvell,mmp3-hsic-phy",
-					     "usb-nop-xceiv";
+				compatible = "marvell,mmp3-hsic-phy";
 				reg = <0xf0002800 0x40>;
 				#phy-cells = <0>;
 				status = "disabled";
-- 
2.26.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 14/15] ARM: dts: mmp3: Use the MMP3 compatible string for /clocks
       [not found] <20200419171157.672999-1-lkundrak@v3.sk>
  2020-04-19 17:11 ` [PATCH 13/15] ARM: dts: mmp3: Drop usb-nop-xceiv from HSIC phy Lubomir Rintel
@ 2020-04-19 17:11 ` Lubomir Rintel
  2020-04-19 17:11 ` [PATCH 15/15] ARM: dts: mmp3-dell-ariel: Fix the SPI devices Lubomir Rintel
  2 siblings, 0 replies; 3+ messages in thread
From: Lubomir Rintel @ 2020-04-19 17:11 UTC (permalink / raw)
  To: soc
  Cc: Olof Johansson, Arnd Bergmann, Linux ARM, Daniel Mack,
	Haojian Zhuang, Robert Jarzmik, linux-kernel, Lubomir Rintel,
	stable

Clocks are in fact slightly different on MMP3. In particular, PLL2 is
fixed to a different frequency, there's an extra PLL3, and the GPU
clocks are configured differently.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Cc: <stable@vger.kernel.org>
---
 arch/arm/boot/dts/mmp3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi
index f97fb64404659..57231d49d9386 100644
--- a/arch/arm/boot/dts/mmp3.dtsi
+++ b/arch/arm/boot/dts/mmp3.dtsi
@@ -539,7 +539,7 @@ l2: cache-controller@d0020000 {
 		};
 
 		soc_clocks: clocks@d4050000 {
-			compatible = "marvell,mmp2-clock";
+			compatible = "marvell,mmp3-clock";
 			reg = <0xd4050000 0x1000>,
 			      <0xd4282800 0x400>,
 			      <0xd4015000 0x1000>;
-- 
2.26.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 15/15] ARM: dts: mmp3-dell-ariel: Fix the SPI devices
       [not found] <20200419171157.672999-1-lkundrak@v3.sk>
  2020-04-19 17:11 ` [PATCH 13/15] ARM: dts: mmp3: Drop usb-nop-xceiv from HSIC phy Lubomir Rintel
  2020-04-19 17:11 ` [PATCH 14/15] ARM: dts: mmp3: Use the MMP3 compatible string for /clocks Lubomir Rintel
@ 2020-04-19 17:11 ` Lubomir Rintel
  2 siblings, 0 replies; 3+ messages in thread
From: Lubomir Rintel @ 2020-04-19 17:11 UTC (permalink / raw)
  To: soc
  Cc: Olof Johansson, Arnd Bergmann, Linux ARM, Daniel Mack,
	Haojian Zhuang, Robert Jarzmik, linux-kernel, Lubomir Rintel,
	stable

I've managed to get about everything wrong while digging these out of
OEM's board file.

Correct the bus numbers, the exact model of the NOR flash, polarity of
the chip selects and align the SPI frequency with the data sheet.

Tested that it works now, with a slight fix to the PXA SSP driver.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Cc: <stable@vger.kernel.org>
---
 arch/arm/boot/dts/mmp3-dell-ariel.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/mmp3-dell-ariel.dts b/arch/arm/boot/dts/mmp3-dell-ariel.dts
index 15449c72c042b..b0ec14c421641 100644
--- a/arch/arm/boot/dts/mmp3-dell-ariel.dts
+++ b/arch/arm/boot/dts/mmp3-dell-ariel.dts
@@ -98,19 +98,19 @@ &twsi4 {
 	status = "okay";
 };
 
-&ssp3 {
+&ssp1 {
 	status = "okay";
-	cs-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
+	cs-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
 
 	firmware-flash@0 {
-		compatible = "st,m25p80", "jedec,spi-nor";
+		compatible = "winbond,w25q32", "jedec,spi-nor";
 		reg = <0>;
-		spi-max-frequency = <40000000>;
+		spi-max-frequency = <104000000>;
 		m25p,fast-read;
 	};
 };
 
-&ssp4 {
-	cs-gpios = <&gpio 56 GPIO_ACTIVE_HIGH>;
+&ssp2 {
+	cs-gpios = <&gpio 56 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
-- 
2.26.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-19 17:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200419171157.672999-1-lkundrak@v3.sk>
2020-04-19 17:11 ` [PATCH 13/15] ARM: dts: mmp3: Drop usb-nop-xceiv from HSIC phy Lubomir Rintel
2020-04-19 17:11 ` [PATCH 14/15] ARM: dts: mmp3: Use the MMP3 compatible string for /clocks Lubomir Rintel
2020-04-19 17:11 ` [PATCH 15/15] ARM: dts: mmp3-dell-ariel: Fix the SPI devices Lubomir Rintel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).