From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: fabrice.gasnier@st.com, Jonathan.Cameron@huawei.com,
Stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] iio: adc: stm32-adc: fix device used to request dma" failed to apply to 5.4-stable tree
Date: Tue, 26 May 2020 08:59:30 +0200 [thread overview]
Message-ID: <20200526065930.GA2624088@kroah.com> (raw)
In-Reply-To: <20200525205201.GZ33628@sasha-vm>
On Mon, May 25, 2020 at 04:52:01PM -0400, Sasha Levin wrote:
> On Mon, May 25, 2020 at 03:53:32PM +0200, gregkh@linuxfoundation.org wrote:
> >
> > The patch below does not apply to the 5.4-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------ original commit in Linus's tree ------------------
> >
> > > From 52cd91c27f3908b88e8b25aed4a4d20660abcc45 Mon Sep 17 00:00:00 2001
> > From: Fabrice Gasnier <fabrice.gasnier@st.com>
> > Date: Thu, 30 Apr 2020 11:28:45 +0200
> > Subject: [PATCH] iio: adc: stm32-adc: fix device used to request dma
> >
> > DMA channel request should use device struct from platform device struct.
> > Currently it's using iio device struct. But at this stage when probing,
> > device struct isn't yet registered (e.g. device_register is done in
> > iio_device_register). Since commit 71723a96b8b1 ("dmaengine: Create
> > symlinks between DMA channels and slaves"), a warning message is printed
> > as the links in sysfs can't be created, due to device isn't yet registered:
> > - Cannot create DMA slave symlink
> > - Cannot create DMA dma:rx symlink
> >
> > Fix this by using device struct from platform device to request dma chan.
> >
> > Fixes: 2763ea0585c99 ("iio: adc: stm32: add optional dma support")
> >
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > Cc: <Stable@vger.kernel.org>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> I've also grabbed 735404b846df ("iio: adc: stm32-adc: Use
> dma_request_chan() instead dma_request_slave_channel()") and queued both
> for 5.4, 4.19, and 4.14.
Thanks for this, and all of the other fixups you added to the queue.
greg k-h
prev parent reply other threads:[~2020-05-26 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 13:53 FAILED: patch "[PATCH] iio: adc: stm32-adc: fix device used to request dma" failed to apply to 5.4-stable tree gregkh
2020-05-25 20:52 ` Sasha Levin
2020-05-26 6:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526065930.GA2624088@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Stable@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).