From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40A4C433E1 for ; Fri, 19 Jun 2020 16:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA0F121707 for ; Fri, 19 Jun 2020 16:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592584031; bh=8KQ6F9AGxL2T42f0+XH1LoTkGMUB/lUMpUpOwjWB4Ck=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1KqZUShcVOH2yEZgaX0SZqtWmcTkuAQXI8QeeQ93i4o1o/Brjtro3PCzDTWOSa1ev IrrBBxcjJKD+KB4wluOLeVCEk7cADG3K2zbG6NvOTsbjXN587eB8MmWGOifWy1VLsD /qgWkRnLEdElLAT3eKG3wv4dsBnPH6pO+Dwc6xF4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390395AbgFSQ1K (ORCPT ); Fri, 19 Jun 2020 12:27:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:51370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390064AbgFSO4X (ORCPT ); Fri, 19 Jun 2020 10:56:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DD962184D; Fri, 19 Jun 2020 14:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592578583; bh=8KQ6F9AGxL2T42f0+XH1LoTkGMUB/lUMpUpOwjWB4Ck=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jEh/Teq90J+1+QaGXJ3W4BjuB6MLzTavHoeJG/bcpjSJ+tz8kOEPzJ6hltIlq9pZ3 S2Z7qGmVnk6/TRkxcF6Y1Wy7t3k5HHVWfYoovk52iiL0mrdekGPrGqnoHjJBEf2BhR ICGJSRh0Ao+MuAZ/fbEKrtrkGj1DUB99P+GSbU+s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sumit Saxena , Chandrakanth Patil , "Martin K. Petersen" Subject: [PATCH 4.19 077/267] scsi: megaraid_sas: TM command refire leads to controller firmware crash Date: Fri, 19 Jun 2020 16:31:02 +0200 Message-Id: <20200619141652.584476677@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141648.840376470@linuxfoundation.org> References: <20200619141648.840376470@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sumit Saxena commit 6fd8525a70221c26823b1c7e912fb21f218fb0c5 upstream. When TM command times out, driver invokes the controller reset. Post reset, driver re-fires pended TM commands which leads to firmware crash. Post controller reset, return pended TM commands back to OS. Link: https://lore.kernel.org/r/20200508085242.23406-1-chandrakanth.patil@broadcom.com Cc: stable@vger.kernel.org Signed-off-by: Sumit Saxena Signed-off-by: Chandrakanth Patil Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -3940,6 +3940,7 @@ void megasas_refire_mgmt_cmd(struct mega struct fusion_context *fusion; struct megasas_cmd *cmd_mfi; union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc; + struct MPI2_RAID_SCSI_IO_REQUEST *scsi_io_req; u16 smid; bool refire_cmd = 0; u8 result; @@ -3990,6 +3991,11 @@ void megasas_refire_mgmt_cmd(struct mega break; } + scsi_io_req = (struct MPI2_RAID_SCSI_IO_REQUEST *) + cmd_fusion->io_request; + if (scsi_io_req->Function == MPI2_FUNCTION_SCSI_TASK_MGMT) + result = RETURN_CMD; + switch (result) { case REFIRE_CMD: megasas_fire_cmd_fusion(instance, req_desc); @@ -4187,7 +4193,6 @@ megasas_issue_tm(struct megasas_instance if (!timeleft) { dev_err(&instance->pdev->dev, "task mgmt type 0x%x timed out\n", type); - cmd_mfi->flags |= DRV_DCMD_SKIP_REFIRE; mutex_unlock(&instance->reset_mutex); rc = megasas_reset_fusion(instance->host, MFI_IO_TIMEOUT_OCR); mutex_lock(&instance->reset_mutex);