From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30989C433DF for ; Fri, 19 Jun 2020 15:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03DF021974 for ; Fri, 19 Jun 2020 15:03:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592579024; bh=m/XRWXAKcfR55buGyTcsv2d4DhNlb5CKM6plfkXTgCw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qhj5gUqiVukkBk6ZeFiComlF3/TdwplOw1bEygNgS6WGJ792JVYMkCXH7w24H/HH0 pL+HgToJ1d3BDCAdVSOrX9FFM6DPFnQ9pSn6Wbhl56RtkqsmDKWgyat5ocLsZ7v0UD r+cmWAqT5rk1w1Fy42tPSRpPboZXBjRVh9oFqMUw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391040AbgFSPDm (ORCPT ); Fri, 19 Jun 2020 11:03:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:60434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391036AbgFSPDk (ORCPT ); Fri, 19 Jun 2020 11:03:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FE1A206DB; Fri, 19 Jun 2020 15:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592579020; bh=m/XRWXAKcfR55buGyTcsv2d4DhNlb5CKM6plfkXTgCw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IjEdJSunMxbNJn8wX1nplWLCe4dZgsHVy3GjdrCbEX1kWxJjlQAOaqXJDB3eXJ1jC O3tlZkDnyyiO0ROMtkZt6D5pxQwf/z2fnHy53eek8HtJGAh/pQq8G3hT+plkipEz8l kcggvmxuxM+MSViKfh0N+FdIv9vTk4mQbItiiZIE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Wei Yongjun , Johan Hovold Subject: [PATCH 4.19 245/267] gnss: sirf: fix error return code in sirf_probe() Date: Fri, 19 Jun 2020 16:33:50 +0200 Message-Id: <20200619141700.438090577@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141648.840376470@linuxfoundation.org> References: <20200619141648.840376470@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wei Yongjun commit 43d7ce70ae43dd8523754b17f567417e0e75dbce upstream. Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. This avoids a use-after-free in case the driver is later unbound. Fixes: d2efbbd18b1e ("gnss: add driver for sirfstar-based receivers") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun [ johan: amend commit message; mention potential use-after-free ] Cc: stable # 4.19 Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/gnss/sirf.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/gnss/sirf.c +++ b/drivers/gnss/sirf.c @@ -292,14 +292,18 @@ static int sirf_probe(struct serdev_devi data->on_off = devm_gpiod_get_optional(dev, "sirf,onoff", GPIOD_OUT_LOW); - if (IS_ERR(data->on_off)) + if (IS_ERR(data->on_off)) { + ret = PTR_ERR(data->on_off); goto err_put_device; + } if (data->on_off) { data->wakeup = devm_gpiod_get_optional(dev, "sirf,wakeup", GPIOD_IN); - if (IS_ERR(data->wakeup)) + if (IS_ERR(data->wakeup)) { + ret = PTR_ERR(data->wakeup); goto err_put_device; + } /* * Configurations where WAKEUP has been left not connected,