From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32EEC433DF for ; Tue, 23 Jun 2020 20:48:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFE192098B for ; Tue, 23 Jun 2020 20:48:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945317; bh=/8gCY5X9pERgShbmmKJyfJr5Kwu2OB8VA3tfZ/WPk7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OIIsJiy6u1TnKyAPj1eFrC7tuYvxoPiT429s3gGCHQdqZw8O+v23sO+kcWUG2mQus qE4dVcy9HegEzfJQP7EvDhpIsIaWSUFpjIZ5L1jiLR5o8iDRvZufBsmr8fI5K5Hmy1 gxQhWMhdrb8m2+BddryqTyi+S7rVL2ZFS6pK+8Pk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392946AbgFWUsf (ORCPT ); Tue, 23 Jun 2020 16:48:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:47604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392938AbgFWUsa (ORCPT ); Tue, 23 Jun 2020 16:48:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAAD5217D8; Tue, 23 Jun 2020 20:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945311; bh=/8gCY5X9pERgShbmmKJyfJr5Kwu2OB8VA3tfZ/WPk7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gGewX5VNEZLI6upEkBogkggUSk0fCEy3FGAplXmm76qfU5n1OtYOF+9Usdac9wzdn HNjju/O5UHi+iw53WUzTiLDz/t4D+bSVCwBNUi5bHMreMoVj0G4jsbL0E3m6b6alO0 8m0k2tMJUjdGRop75JO6htPI34K/qtyJNx65Eatg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal , Sasha Levin Subject: [PATCH 4.14 121/136] mtd: rawnand: sharpsl: Fix the probe error path Date: Tue, 23 Jun 2020 21:59:37 +0200 Message-Id: <20200623195309.825152891@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Miquel Raynal [ Upstream commit 0f44b3275b3798ccb97a2f51ac85871c30d6fbbc ] nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no Fixes tag applying here as the use of nand_release() in this driver predates by far the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible. However, pointing this commit as the culprit for backporting purposes makes sense. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-49-miquel.raynal@bootlin.com Signed-off-by: Sasha Levin --- drivers/mtd/nand/sharpsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/sharpsl.c b/drivers/mtd/nand/sharpsl.c index 6cfff0c81153f..c245d66609c1f 100644 --- a/drivers/mtd/nand/sharpsl.c +++ b/drivers/mtd/nand/sharpsl.c @@ -192,7 +192,7 @@ static int sharpsl_nand_probe(struct platform_device *pdev) return 0; err_add: - nand_release(this); + nand_cleanup(this); err_scan: iounmap(sharpsl->io); -- 2.25.1