From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB3AC433E0 for ; Tue, 30 Jun 2020 21:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C0E22053B for ; Tue, 30 Jun 2020 21:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728907AbgF3VJZ (ORCPT ); Tue, 30 Jun 2020 17:09:25 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:50570 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726084AbgF3VJY (ORCPT ); Tue, 30 Jun 2020 17:09:24 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 008FA1C0C0A; Tue, 30 Jun 2020 23:09:21 +0200 (CEST) Date: Tue, 30 Jun 2020 23:09:21 +0200 From: Pavel Machek To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Josef Bacik , David Sterba Subject: Re: [PATCH 4.19 011/131] btrfs: make caching_thread use btrfs_find_next_key Message-ID: <20200630210921.GA2728@duo.ucw.cz> References: <20200629153502.2494656-1-sashal@kernel.org> <20200629153502.2494656-12-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: <20200629153502.2494656-12-sashal@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2020-06-29 11:33:02, Sasha Levin wrote: > From: Josef Bacik >=20 > [ Upstream commit 6a9fb468f1152d6254f49fee6ac28c3cfa3367e5 ] >=20 > extent-tree.c has a find_next_key that just walks up the path to find > the next key, but it is used for both the caching stuff and the snapshot > delete stuff. The snapshot deletion stuff is special so it can't really > use btrfs_find_next_key, but the caching thread stuff can. We just need > to fix btrfs_find_next_key to deal with ->skip_locking and then it works > exactly the same as the private find_next_key helper. >=20 > Signed-off-by: Josef Bacik > Signed-off-by: David Sterba > Signed-off-by: Sasha Levin According to changelog, this is not known to fix a bug. Why is it needed in stable? Best regards, Pavel =09 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXvuqAQAKCRAw5/Bqldv6 8vAxAKDDeBPcwQCmEBCxgg7n9Vy/A5WwDACfR1MHhWupwkJTa9noYLO+HVUQo00= =vZ97 -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--