From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C959C433DF for ; Tue, 14 Jul 2020 18:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D34A20663 for ; Tue, 14 Jul 2020 18:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594752018; bh=x0dDBEgdFinTqqZrQmsDMDD+XlwW4T8ADjvCUjepFAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zKLiTtKtHzXI4ZLntZ9fvxbkI9O+60Nj2cese0aT7PBsMtYkNy6qMiGipvD0SEA99 wRatpLnqZmkJI4wNnWWtMEV3+8Pm+O/gRaa8RVea87iNRqsngDWoeWHdnFIsRkTOvt GxXcAlj2r9cpTb1wMXdsVpgvS/XMVGHfJO040RLU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728312AbgGNSkR (ORCPT ); Tue, 14 Jul 2020 14:40:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:38244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbgGNSkR (ORCPT ); Tue, 14 Jul 2020 14:40:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B86F2242E; Tue, 14 Jul 2020 18:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594752017; bh=x0dDBEgdFinTqqZrQmsDMDD+XlwW4T8ADjvCUjepFAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wH3dkXh+JZ6bV8XkbmfVEdpiLrqNWVTJDwk6Iz/oofwKgZCB51edTP3aF50YhKXKY 3KXzPW1A8ty+eczqIhgKG0+3S8DaTo/KRThWQvfpLw9/NKavo5+tdKAj0eQkjDCe/A WoSTd0gzQH+www+SAOkpnEl3cT8TBs0VmfCzgBBU= Date: Tue, 14 Jul 2020 20:40:13 +0200 From: Greg Kroah-Hartman To: Naresh Kamboju Cc: linux- stable , lkft-triage@lists.linaro.org, Arnd Bergmann , Sasha Levin , Will Deacon , Mark Rutland , Marc Zyngier Subject: Re: stable-rc 5.4: arm64 build =?utf-8?Q?f?= =?utf-8?Q?ailed_-_error=3A_=E2=80=98const_struct_arch=5Ftimer=5Ferratum?= =?utf-8?Q?=5Fworkaround=E2=80=99_has_no_member_named_=E2=80=98disable=5Fc?= =?utf-8?B?b21wYXRfdmRzb+KAmQ==?= Message-ID: <20200714184013.GA2174489@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Jul 14, 2020 at 10:48:14PM +0530, Naresh Kamboju wrote: > arm64 build failed on 5.4 > > make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=arm64 > CROSS_COMPILE=aarch64-linux-gnu- HOSTCC=gcc CC="sccache > aarch64-linux-gnu-gcc" O=build Image > # > ../drivers/clocksource/arm_arch_timer.c:484:4: error: ‘const struct > arch_timer_erratum_workaround’ has no member named > ‘disable_compat_vdso’ > 484 | .disable_compat_vdso = true, > | ^~~~~~~~~~~~~~~~~~~ > ../drivers/clocksource/arm_arch_timer.c:484:26: warning: > initialization of ‘u32 (*)(void)’ {aka ‘unsigned int (*)(void)’} from > ‘int’ makes pointer from integer without a cast [-Wint-conversion] > 484 | .disable_compat_vdso = true, > | ^~~~ > ../drivers/clocksource/arm_arch_timer.c:484:26: note: (near > initialization for ‘ool_workarounds[5].read_cntp_tval_el0’) > > Could be this patch, > arm64: arch_timer: Disable the compat vdso for cores affected by > ARM64_WORKAROUND_1418040 > commit 4b661d6133c5d3a7c9aca0b4ee5a78c7766eff3f upstream. > > ARM64_WORKAROUND_1418040 requires that AArch32 EL0 accesses to > the virtual counter register are trapped and emulated by the kernel. > This makes the vdso pretty pointless, and in some cases livelock > prone. > > Provide a workaround entry that limits the vdso to 64bit tasks. > > Signed-off-by: Marc Zyngier > Acked-by: Mark Rutland > Cc: stable@vger.kernel.org > Link: https://lore.kernel.org/r/20200706163802.1836732-4-maz@kernel.org > Signed-off-by: Will Deacon > Signed-off-by: Greg Kroah-Hartman > > > ref: > https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/638094006 Thanks, I've now dropped this patch. greg k-h