From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0816C433E5 for ; Mon, 20 Jul 2020 16:04:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B338420773 for ; Mon, 20 Jul 2020 16:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595261068; bh=LinykegGTx4SBUpY0BV2ODu2MgLAznZspWm1iZtzBfc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qYncXi7jcyxnWLYzsQaRC0rsIWzMHyZFtX90WNBOAG5HTpcFS5gwPnq9R2AqnEoIT fD31G8uw1z7ZctSp+5k8Elh3viivv8XRB+JuBqQTHVs9xvy6mB7IiXSuJEOgz2OFOO 44u0uav5USZ/WZhjgJj151fxfEhJpXZQQmPGF+ac= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732634AbgGTQE1 (ORCPT ); Mon, 20 Jul 2020 12:04:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:39260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732549AbgGTQEZ (ORCPT ); Mon, 20 Jul 2020 12:04:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E43CF20672; Mon, 20 Jul 2020 16:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595261065; bh=LinykegGTx4SBUpY0BV2ODu2MgLAznZspWm1iZtzBfc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l1twotgkt2/mO2oJPAoyIY97h3Eiu7IaPYyAdW06RgktEOXSpHdkVLSlX9tzlOmGA q28HlhBUEmhFyDsyNbao3zRX4muYAC1W1kFyx4pyLlLbYClVqTgYv7Q9I+L4wprxmA wkaqGVWeyZ1ynSRjaIAQGmWZOincfXMI9pNoWMa4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Kiszka , Michal Simek Subject: [PATCH 5.4 166/215] Revert "tty: xilinx_uartps: Fix missing id assignment to the console" Date: Mon, 20 Jul 2020 17:37:28 +0200 Message-Id: <20200720152828.073421311@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152820.122442056@linuxfoundation.org> References: <20200720152820.122442056@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jan Kiszka commit 76ed2e105796710cf5b8a4ba43c81eceed948b70 upstream. This reverts commit 2ae11c46d5fdc46cb396e35911c713d271056d35. It turned out to break the ultra96-rev1, e.g., which uses uart1 as serial0 (and stdout-path = "serial0:115200n8"). Fixes: 2ae11c46d5fd ("tty: xilinx_uartps: Fix missing id assignment to the console") Cc: stable Signed-off-by: Jan Kiszka Reviewed-by: Michal Simek Tested-by: Michal Simek Link: https://lore.kernel.org/r/f4092727-d8f5-5f91-2c9f-76643aace993@siemens.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/xilinx_uartps.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1445,7 +1445,6 @@ static int cdns_uart_probe(struct platfo cdns_uart_uart_driver.nr = CDNS_UART_NR_PORTS; #ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE cdns_uart_uart_driver.cons = &cdns_uart_console; - cdns_uart_console.index = id; #endif rc = uart_register_driver(&cdns_uart_uart_driver);