From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C8D4C433E3 for ; Mon, 27 Jul 2020 14:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D87A9207FC for ; Mon, 27 Jul 2020 14:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595860484; bh=WuELeavyDRx8mw9ik3oLaPzKVsJbeveplcMAf2xPW3I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xtJ4oMm2P47mp1/7pxboW/z3gV+NP4HOqOE0UX0340QgZHEnm5/EDRNMi6Rl91uBe t+r1ty8F3RyU33p3yN9LmAvEJTn/FrkfTQSr7wfWiFYmayiiZAZlKOFpw7j2cmrQKa SLaYr5fl54zuqQSIUNaV7/x/xOA0+RI2zpj886OU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730797AbgG0OQH (ORCPT ); Mon, 27 Jul 2020 10:16:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:42912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730218AbgG0OQG (ORCPT ); Mon, 27 Jul 2020 10:16:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97C8F2070A; Mon, 27 Jul 2020 14:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859366; bh=WuELeavyDRx8mw9ik3oLaPzKVsJbeveplcMAf2xPW3I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ingegwo326Mqgtf7VZWZuh5qyKzuE6UYoXp3DTayMxvf4YTuvwBiz5HQ/+lsjHhhv Ww5x9l/nxL/lF0OrMoOCygiJDyjP2fxAM4pHWEnnib4GHKcGs5u9enp1WTKTN8Rr6Q gIMr5eUFsLUUj+E3Sq4V9uswJF3KOKWQ7NBVNzTo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Evgeny Novikov , Guenter Roeck , Sasha Levin Subject: [PATCH 5.4 080/138] hwmon: (aspeed-pwm-tacho) Avoid possible buffer overflow Date: Mon, 27 Jul 2020 16:04:35 +0200 Message-Id: <20200727134929.378074280@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134925.228313570@linuxfoundation.org> References: <20200727134925.228313570@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Evgeny Novikov [ Upstream commit bc4071aafcf4d0535ee423b69167696d6c03207d ] aspeed_create_fan() reads a pwm_port value using of_property_read_u32(). If pwm_port will be more than ARRAY_SIZE(pwm_port_params), there will be a buffer overflow in aspeed_create_pwm_port()->aspeed_set_pwm_port_enable(). The patch fixes the potential buffer overflow. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov Link: https://lore.kernel.org/r/20200703111518.9644-1-novikov@ispras.ru Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/aspeed-pwm-tacho.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c index 40c489be62eaa..40f3139f1e028 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -851,6 +851,8 @@ static int aspeed_create_fan(struct device *dev, ret = of_property_read_u32(child, "reg", &pwm_port); if (ret) return ret; + if (pwm_port >= ARRAY_SIZE(pwm_port_params)) + return -EINVAL; aspeed_create_pwm_port(priv, (u8)pwm_port); ret = of_property_count_u8_elems(child, "cooling-levels"); -- 2.25.1