From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528FDC4346B for ; Mon, 27 Jul 2020 23:27:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2166D2173E for ; Mon, 27 Jul 2020 23:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595892429; bh=bTEMXvdIvyE2iqBAS9NC+cQYJQ88tOHYymR7wqxovZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aiWxEFcZ/N9PGLpN/zT1Knux8H5x3c7ZRxUkvvAh7sTgLEXcoC/coaNT4nJ0zTXwn f5y/QofKNdKXIBDHVX7Y6w5af2XvRuhWe7YYuNGjNdC/D0DelM1W7S8Ty1f6MVm1NG 15BZ+JqBWgBYm5lt/b0u+Es3A2K/RQqamZDOJRJM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728185AbgG0X1C (ORCPT ); Mon, 27 Jul 2020 19:27:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:36290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728437AbgG0XZD (ORCPT ); Mon, 27 Jul 2020 19:25:03 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B833208E4; Mon, 27 Jul 2020 23:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595892303; bh=bTEMXvdIvyE2iqBAS9NC+cQYJQ88tOHYymR7wqxovZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OHdmhMWVgRNQV+BJcEW+qmW0Ltt9Ra4Zle+Qx7PlRew5Jafyj4U7SdpOuisiu7bZ4 HSa2nDRUfeSFp7enX6b38tnGX9cO3oRWGstltAvzx3PkNl2gT0DjoiddWY5yxaM+El QWSMuVjDyACkd/J2uzx9QaFsPGuZSjuYBplCFEGo= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Navid Emamdoost , "David S . Miller" , Sasha Levin , linux-nfc@lists.01.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 03/10] nfc: s3fwrn5: add missing release on skb in s3fwrn5_recv_frame Date: Mon, 27 Jul 2020 19:24:51 -0400 Message-Id: <20200727232458.718131-3-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200727232458.718131-1-sashal@kernel.org> References: <20200727232458.718131-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Navid Emamdoost [ Upstream commit 1e8fd3a97f2d83a7197876ceb4f37b4c2b00a0f3 ] The implementation of s3fwrn5_recv_frame() is supposed to consume skb on all execution paths. Release skb before returning -ENODEV. Signed-off-by: Navid Emamdoost Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/nfc/s3fwrn5/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nfc/s3fwrn5/core.c b/drivers/nfc/s3fwrn5/core.c index 9d9c8d57a042d..64b58455e620b 100644 --- a/drivers/nfc/s3fwrn5/core.c +++ b/drivers/nfc/s3fwrn5/core.c @@ -209,6 +209,7 @@ int s3fwrn5_recv_frame(struct nci_dev *ndev, struct sk_buff *skb, case S3FWRN5_MODE_FW: return s3fwrn5_fw_recv_frame(ndev, skb); default: + kfree_skb(skb); return -ENODEV; } } -- 2.25.1