Stable Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] iio: trigger: hrtimer: Disable irqs before calling iio_trigger_poll()
@ 2020-07-27 14:58 Christian Eggers
  2020-07-30 13:48 ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Eggers @ 2020-07-27 14:58 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Christian Eggers, stable, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler, Geert Uytterhoeven, Alexandru Ardelean,
	linux-iio, linux-kernel

iio_trigger_poll() calls generic_handle_irq(). This function expects to
be run with local IRQs disabled.

Signed-off-by: Christian Eggers <ceggers@arri.de>
Cc: stable@vger.kernel.org
---
 drivers/iio/trigger/iio-trig-hrtimer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/iio/trigger/iio-trig-hrtimer.c b/drivers/iio/trigger/iio-trig-hrtimer.c
index f59bf8d58586..2fe8a5c1484e 100644
--- a/drivers/iio/trigger/iio-trig-hrtimer.c
+++ b/drivers/iio/trigger/iio-trig-hrtimer.c
@@ -89,7 +89,9 @@ static enum hrtimer_restart iio_hrtimer_trig_handler(struct hrtimer *timer)
 	info = container_of(timer, struct iio_hrtimer_info, timer);
 
 	hrtimer_forward_now(timer, info->period);
+	local_irq_disable();
 	iio_trigger_poll(info->swt.trigger);
+	local_irq_enable();
 
 	return HRTIMER_RESTART;
 }
-- 
Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] iio: trigger: hrtimer: Disable irqs before calling iio_trigger_poll()
  2020-07-27 14:58 [PATCH 1/2] iio: trigger: hrtimer: Disable irqs before calling iio_trigger_poll() Christian Eggers
@ 2020-07-30 13:48 ` Sasha Levin
  2020-08-03  5:16   ` Christian Eggers
  0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2020-07-30 13:48 UTC (permalink / raw)
  To: Sasha Levin, Christian Eggers, Jonathan Cameron
  Cc: Christian Eggers, stable, stable, stable

Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.7.11, v5.4.54, v4.19.135, v4.14.190, v4.9.231, v4.4.231.

v5.7.11: Build OK!
v5.4.54: Build OK!
v4.19.135: Build OK!
v4.14.190: Build OK!
v4.9.231: Build OK!
v4.4.231: Failed to apply! Possible dependencies:
    ac5006a2a558 ("iio: trigger: Introduce IIO hrtimer based trigger")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] iio: trigger: hrtimer: Disable irqs before calling iio_trigger_poll()
  2020-07-30 13:48 ` Sasha Levin
@ 2020-08-03  5:16   ` Christian Eggers
  0 siblings, 0 replies; 3+ messages in thread
From: Christian Eggers @ 2020-08-03  5:16 UTC (permalink / raw)
  To: Sasha Levin; +Cc: Jonathan Cameron, stable

On Thursday, 30 July 2020, 15:48:11 CEST, Sasha Levin wrote:
> The bot has tested the following trees: v5.7.11, v5.4.54, v4.19.135,
> v4.14.190, v4.9.231, v4.4.231.
> 
> v5.7.11: Build OK!
> v5.4.54: Build OK!
> v4.19.135: Build OK!
> v4.14.190: Build OK!
> v4.9.231: Build OK!
> v4.4.231: Failed to apply! Possible dependencies:
>     ac5006a2a558 ("iio: trigger: Introduce IIO hrtimer based trigger")
> 
> 
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?
Please apply for v4.9 and later.

regards
Christian




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 14:58 [PATCH 1/2] iio: trigger: hrtimer: Disable irqs before calling iio_trigger_poll() Christian Eggers
2020-07-30 13:48 ` Sasha Levin
2020-08-03  5:16   ` Christian Eggers

Stable Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://lore.kernel.org/stable \
		stable@vger.kernel.org
	public-inbox-index stable

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git