From: Greg KH <gregkh@linuxfoundation.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: stable@vger.kernel.org
Subject: Re: Nominate "PCI/ASPM: Disable ASPM on ASMedia ASM1083/1085 PCIe-to-PCI bridge" for stable
Date: Sat, 1 Aug 2020 12:36:30 +0200 [thread overview]
Message-ID: <20200801103630.GC3046974@kroah.com> (raw)
In-Reply-To: <CADLC3L20-OaNXhNQ-uW29XPQv0uus8zwLcv=vk-YGL=0P3sdeA@mail.gmail.com>
On Thu, Jul 30, 2020 at 07:22:22PM -0600, Robert Hancock wrote:
> I would like to nominate the following commit, now in mainline, for
> stable. This fixes an issue exposed by commit 66ff14e59e8a ("PCI/ASPM:
> Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges") and so should go
> into all stable branches which that was backported to (which appears
> to be all of the currently maintained releases).
>
> commit b361663c5a40c8bc758b7f7f2239f7a192180e7c
> Author: Robert Hancock <hancockrwd@gmail.com>
> Date: Tue Jul 21 20:18:03 2020 -0600
>
> PCI/ASPM: Disable ASPM on ASMedia ASM1083/1085 PCIe-to-PCI bridge
>
> Recently ASPM handling was changed to allow ASPM on PCIe-to-PCI/PCI-X
> bridges. Unfortunately the ASMedia ASM1083/1085 PCIe to PCI bridge device
> doesn't seem to function properly with ASPM enabled. On an Asus PRIME
> H270-PRO motherboard, it causes errors like these:
>
> pcieport 0000:00:1c.0: AER: PCIe Bus Error: severity=Corrected,
> type=Data Link Layer, (Transmitter ID)
> pcieport 0000:00:1c.0: AER: device [8086:a292] error
> status/mask=00003000/00002000
> pcieport 0000:00:1c.0: AER: [12] Timeout
> pcieport 0000:00:1c.0: AER: Corrected error received: 0000:00:1c.0
> pcieport 0000:00:1c.0: AER: can't find device of ID00e0
>
> In addition to flooding the kernel log, this also causes the machine to
> wake up immediately after suspend is initiated.
>
> The device advertises ASPM L0s and L1 support in the Link Capabilities
> register, but the ASMedia web page for ASM1083 [1] claims "No PCIe ASPM
> support".
>
> Windows 10 (build 2004) enables L0s, but it also logs correctable PCIe
> errors.
>
> Add a quirk to disable ASPM for this device.
>
> [1] https://www.asmedia.com.tw/eng/e_show_products.php?cate_index=169&item=114
>
> [bhelgaas: commit log]
> Fixes: 66ff14e59e8a ("PCI/ASPM: Allow ASPM on links to
> PCIe-to-PCI/PCI-X Bridges")
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208667
> Link: https://lore.kernel.org/r/20200722021803.17958-1-hancockrwd@gmail.com
> Signed-off-by: Robert Hancock <hancockrwd@gmail.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Now queued up everywhere, thansk!
greg k-h
prev parent reply other threads:[~2020-08-01 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 1:22 Nominate "PCI/ASPM: Disable ASPM on ASMedia ASM1083/1085 PCIe-to-PCI bridge" for stable Robert Hancock
2020-08-01 10:36 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200801103630.GC3046974@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hancockrwd@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).