From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7207C433E1 for ; Mon, 3 Aug 2020 12:37:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF2872076B for ; Mon, 3 Aug 2020 12:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596458254; bh=kqcywWGddGmtjDrZKdet1vVd3gNVviqsHGbJfram3ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jktEefJewIg4P9DEwtPygwUvoSLoEDv1/rc8mvEW0OoX274xZ6XdNlc5aPif8j5pC zfJf9Ggfgvha0xPp4AErur6VKw/CSEByragQ5DSkaUgjTRy5QAy2Qlcfr3D3xKcveB qawNiMQ+BMx+bcLIu26sQv7zMTVicR3BqtMXuM3o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729102AbgHCMey (ORCPT ); Mon, 3 Aug 2020 08:34:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:35174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728665AbgHCMex (ORCPT ); Mon, 3 Aug 2020 08:34:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D1C020775; Mon, 3 Aug 2020 12:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596458092; bh=kqcywWGddGmtjDrZKdet1vVd3gNVviqsHGbJfram3ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NJM8hvc6ey0kP3+uvnYOKrNgZemzOI8m5M6d4nwaQjZehP0wKnkox4hwp67Mq5fTD vIKEnMVtlkXAH2mt7GaYTTAVPu2xPaALXC55j7DkC4feWQBtvFRaP9kcyMlBK6oCGi zhAVwGMsvWJ6e2X2YlGEY2eqKCpgIopnFpeF/csw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thomas Falcon , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 35/51] ibmvnic: Fix IRQ mapping disposal in error path Date: Mon, 3 Aug 2020 14:20:20 +0200 Message-Id: <20200803121851.253105600@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200803121849.488233135@linuxfoundation.org> References: <20200803121849.488233135@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Thomas Falcon [ Upstream commit 27a2145d6f826d1fad9de06ac541b1016ced3427 ] RX queue IRQ mappings are disposed in both the TX IRQ and RX IRQ error paths. Fix this and dispose of TX IRQ mappings correctly in case of an error. Fixes: ea22d51a7831 ("ibmvnic: simplify and improve driver probe function") Signed-off-by: Thomas Falcon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 85c11dafb4cd9..8b8a0c4fbc993 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -2324,7 +2324,7 @@ req_rx_irq_failed: req_tx_irq_failed: for (j = 0; j < i; j++) { free_irq(adapter->tx_scrq[j]->irq, adapter->tx_scrq[j]); - irq_dispose_mapping(adapter->rx_scrq[j]->irq); + irq_dispose_mapping(adapter->tx_scrq[j]->irq); } release_sub_crqs(adapter); return rc; -- 2.25.1